Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: runtime/vm/assembler_mips.cc

Issue 2752013003: Improve instruction scheduling when calling the store buffer stub. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips.cc
diff --git a/runtime/vm/assembler_mips.cc b/runtime/vm/assembler_mips.cc
index 00ebd259fd0c06026921b16c2959120a140079b6..7660e2526dc73758a9b16ce24ab38937bc3b081e 100644
--- a/runtime/vm/assembler_mips.cc
+++ b/runtime/vm/assembler_mips.cc
@@ -545,8 +545,9 @@ void Assembler::BranchLinkPatchable(const StubEntry& stub_entry) {
void Assembler::BranchLinkToRuntime() {
lw(T9, Address(THR, Thread::call_to_runtime_entry_point_offset()));
- lw(CODE_REG, Address(THR, Thread::call_to_runtime_stub_offset()));
jalr(T9);
+ delay_slot()->lw(CODE_REG,
+ Address(THR, Thread::call_to_runtime_stub_offset()));
}
@@ -701,9 +702,10 @@ void Assembler::StoreIntoObject(Register object,
if (object != T0) {
mov(T0, object);
}
- lw(CODE_REG, Address(THR, Thread::update_store_buffer_code_offset()));
lw(T9, Address(THR, Thread::update_store_buffer_entry_point_offset()));
jalr(T9);
+ delay_slot()->lw(CODE_REG,
+ Address(THR, Thread::update_store_buffer_code_offset()));
lw(RA, Address(SP, 0 * kWordSize));
if (value != T0) {
// Restore T0.
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698