runtime/vm/assembler_arm64.cc - Issue 2752013003: Improve instruction scheduling when calling the store buffer stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 2752013003: Improve instruction scheduling when calling the store buffer stub. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/assembler_arm64.cc

diff --git a/runtime/vm/assembler_arm64.cc b/runtime/vm/assembler_arm64.cc

index 1b983876dec7ca5c987130f5e350c77f9e9da2d6..151c9839f9e000456d62ca844b87d8ad547e0d73 100644

--- a/runtime/vm/assembler_arm64.cc

+++ b/runtime/vm/assembler_arm64.cc

@@ -909,8 +909,8 @@ void Assembler::StoreIntoObject(Register object,

if (object != R0) {

mov(R0, object);

}

- ldr(CODE_REG, Address(THR, Thread::update_store_buffer_code_offset()));

ldr(TMP, Address(THR, Thread::update_store_buffer_entry_point_offset()));

+ ldr(CODE_REG, Address(THR, Thread::update_store_buffer_code_offset()));

blr(TMP);

Pop(LR);

if (value != R0) {

« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »