Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1788)

Issue 2752013002: Removed webControllerDidUpdateSSLStatusForCurrentNavigationItem:. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed webControllerDidUpdateSSLStatusForCurrentNavigationItem:. Replaced with WebStateDelegate::DidChangeVisibleSecurityState which mirrors content API. BUG=674991 Review-Url: https://codereview.chromium.org/2752013002 Cr-Commit-Position: refs/heads/master@{#457178} Committed: https://chromium.googlesource.com/chromium/src/+/2cb5737f8749a43688c6bcb08f207176409fcae3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -38 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 chunk +6 lines, -6 lines 0 comments Download
M ios/web/public/test/fakes/crw_test_web_state_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/crw_test_web_state_observer.mm View 3 chunks +14 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state_observer.h View 3 chunks +8 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state_observer.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state_observer_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/web/public/web_state/web_state_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/public/web_state/web_state_observer_bridge.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 5 chunks +8 lines, -18 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 3 chunks +46 lines, -14 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge_unittest.mm View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 9 months ago (2017-03-15 17:33:29 UTC) #6
rohitrao (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-15 18:48:39 UTC) #7
Eugene But (OOO till 7-30)
Thanks for quick review!
3 years, 9 months ago (2017-03-15 19:55:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752013002/1
3 years, 9 months ago (2017-03-15 19:55:50 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 20:03:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2cb5737f8749a43688c6bcb08f20...

Powered by Google App Engine
This is Rietveld 408576698