Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 27520004: Merge 226767 "Do not transform scroll event ordinal values" (Closed)

Created:
7 years, 2 months ago by benhenry
Modified:
7 years, 2 months ago
Reviewers:
Shecky Lin
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Merge 226767 "Do not transform scroll event ordinal values" > Do not transform scroll event ordinal values > > We don't need to transform scroll event ordinal values anymore as > we now interpret them as DIPs across the whole stack. Otherwise, > high-DPI devices (e.g. Pixel) would see the overscroll sensitivity > downscaled by the device scale factor. > > Contributed by sheckylin@chromium.org > > BUG=300059 > TEST=Make sure it takes roughly the same distance to scroll on the > touchpad to trigger the back/forward history navigation gesture on > both Pixel and other low-res devices. > > Review URL: https://codereview.chromium.org/25373005 TBR=sheckylin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
ash/display/display_controller_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
ash/display/root_window_transformers_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
ui/events/event.h View 1 chunk +0 lines, -4 lines 0 comments Download
ui/events/event.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
benhenry
7 years, 2 months ago (2013-10-16 15:54:31 UTC) #1
benhenry
7 years, 2 months ago (2013-10-16 15:54:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r228921.

Powered by Google App Engine
This is Rietveld 408576698