Do not transform scroll event ordinal values

Do not transform scroll event ordinal values

We don't need to transform scroll event ordinal values anymore as
we now interpret them as DIPs across the whole stack. Otherwise,
high-DPI devices (e.g. Pixel) would see the overscroll sensitivity
downscaled by the device scale factor.

Contributed by sheckylin@chromium.org

BUG=300059
TEST=Make sure it takes roughly the same distance to scroll on the
touchpad to trigger the back/forward history navigation gesture on
both Pixel and other low-res devices.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226767

[Shecky Lin, 2013-10-01 09:28:18]

Sadrul: could you help review the change? Thanks!

[sadrul, 2013-10-01 11:17:06]

LGTM with the change. Please wait for review from Dave before landing.

https://codereview.chromium.org/25373005/diff/1/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/25373005/diff/1/ui/events/event.cc#newcode728
ui/events/event.cc:728: void ScrollEvent::UpdateForRootTransform(
You should just remove this override.

[Shecky Lin, 2013-10-02 02:50:55]

Thanks! Dave, could take a look of this?

On 2013/10/01 11:17:06, sadrul wrote:
> LGTM with the change. Please wait for review from Dave before landing.
> 
> https://codereview.chromium.org/25373005/diff/1/ui/events/event.cc
> File ui/events/event.cc (right):
> 
> https://codereview.chromium.org/25373005/diff/1/ui/events/event.cc#newcode728
> ui/events/event.cc:728: void ScrollEvent::UpdateForRootTransform(
> You should just remove this override.

[DaveMoore, 2013-10-02 16:14:18]

lgtm

[commit-bot: I haz the power, 2013-10-03 02:59:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheckylin@chromium.org/25373005/6001

[commit-bot: I haz the power, 2013-10-03 04:19:04]

Retried try job too often on linux_chromeos for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Shecky Lin, 2013-10-03 04:27:08]

Oops, sorry. oshima: could you help review the change on ash unittests? Thanks!

[oshima, 2013-10-03 09:23:42]

lgtm with nits

https://codereview.chromium.org/25373005/diff/34001/ash/display/display_contr...
File ash/display/display_controller_unittest.cc (right):

https://codereview.chromium.org/25373005/diff/34001/ash/display/display_contr...
ash/display/display_controller_unittest.cc:1151: // With device scale factor =
2, ordinal_offset * 2 = offset.
can you update the comment?

https://codereview.chromium.org/25373005/diff/34001/ash/display/root_window_t...
File ash/display/root_window_transformers_unittest.cc (left):

https://codereview.chromium.org/25373005/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers_unittest.cc:301: // With device scale
factor = 2, ordinal_offset * 2 = offset.
ditto

[Shecky Lin, 2013-10-03 09:47:11]

Done. Thanks!

https://codereview.chromium.org/25373005/diff/34001/ash/display/display_contr...
File ash/display/display_controller_unittest.cc (right):

https://codereview.chromium.org/25373005/diff/34001/ash/display/display_contr...
ash/display/display_controller_unittest.cc:1151: // With device scale factor =
2, ordinal_offset * 2 = offset.
On 2013/10/03 09:23:43, oshima wrote:
> can you update the comment?

Done.

[commit-bot: I haz the power, 2013-10-03 09:48:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheckylin@chromium.org/25373005/38001

[commit-bot: I haz the power, 2013-10-03 11:00:53]

Retried try job too often on linux_chromeos for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-10-03 13:23:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheckylin@chromium.org/25373005/64001

[commit-bot: I haz the power, 2013-10-03 15:51:22]

Change committed as 226767