Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2751993002: [assembler] Remove unnecessary cast. (Closed)

Created:
3 years, 9 months ago by neis
Modified:
3 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[assembler] Remove unnecessary cast. BUG= Review-Url: https://codereview.chromium.org/2751993002 Cr-Commit-Position: refs/heads/master@{#43845} Committed: https://chromium.googlesource.com/v8/v8/+/b16630cfd41f9bef5ed3ed505b13fcac29bb3ea2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M src/arm/assembler-arm-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/s390/assembler-s390-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
neis
ptal (The Object* -> Code* change is just for clarity -- the function takes Object* ...
3 years, 9 months ago (2017-03-15 14:50:27 UTC) #5
Jarin
lgtm
3 years, 9 months ago (2017-03-16 05:24:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751993002/1
3 years, 9 months ago (2017-03-16 07:56:52 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 07:58:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b16630cfd41f9bef5ed3ed505b13fcac29b...

Powered by Google App Engine
This is Rietveld 408576698