|
|
DescriptionDisable 4 PDFExtensionTest test cases as they fail on multiple bots.
BUG=701427
Review-Url: https://codereview.chromium.org/2751973009
Cr-Commit-Position: refs/heads/master@{#457908}
Committed: https://chromium.googlesource.com/chromium/src/+/a5082d6ce45219eba13fae950a5fbdda07fe3442
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
krasin@chromium.org changed reviewers: + jochen@chromium.org
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thestig@chromium.org changed reviewers: + thestig@chromium.org
Do you want to disable only in official builds, or something like that rather than everywhere? This isn't failing everywhere, right?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Disable 4 PDFExtensionTest test cases as they fail on multiple bots. BUG=701427 ========== to ========== Disable 4 PDFExtensionTest test cases as they fail on multiple bots. BUG=701427 ==========
On 2017/03/17 21:36:14, Lei Zhang (super slow) wrote: > Do you want to disable only in official builds, or something like that rather > than everywhere? This isn't failing everywhere, right? This is failing on many configurations, but not all. My main wish here is to have these tests fixed (the bug is assigned to the test author), and it seems that disabling the tests everywhere will make it more probable that the issue will be fixed sooner than later. Nico, what would be your recommendation in this case?
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm I hope we'll just fix it soon.
The CQ bit was unchecked by krasin@chromium.org
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/17 22:35:16, krasin1 wrote: > On 2017/03/17 21:36:14, Lei Zhang (super slow) wrote: > > Do you want to disable only in official builds, or something like that rather > > than everywhere? This isn't failing everywhere, right? > > This is failing on many configurations, but not all. > > My main wish here is to have these tests fixed (the bug is assigned to the test > author), and it seems that disabling the tests everywhere will make it more > probable that the issue will be fixed sooner than later. > > Nico, what would be your recommendation in this case? TBH I'd revert the change that added the tests, if they're new.
On 2017/03/17 22:44:26, Nico wrote: > On 2017/03/17 22:35:16, krasin1 wrote: > > On 2017/03/17 21:36:14, Lei Zhang (super slow) wrote: > > > Do you want to disable only in official builds, or something like that > rather > > > than everywhere? This isn't failing everywhere, right? > > > > This is failing on many configurations, but not all. > > > > My main wish here is to have these tests fixed (the bug is assigned to the > test > > author), and it seems that disabling the tests everywhere will make it more > > probable that the issue will be fixed sooner than later. > > > > Nico, what would be your recommendation in this case? > > TBH I'd revert the change that added the tests, if they're new. The tests are not very new. They are added in July 2016. It's unclear what is even broken, but only these tests seem to be affected by the issue.
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1489790278892000, "parent_rev": "7a3fcb2ef0b8eb5b737ad64f697ae9bc520a0a95", "commit_rev": "a5082d6ce45219eba13fae950a5fbdda07fe3442"}
Message was sent while issue was closed.
Description was changed from ========== Disable 4 PDFExtensionTest test cases as they fail on multiple bots. BUG=701427 ========== to ========== Disable 4 PDFExtensionTest test cases as they fail on multiple bots. BUG=701427 Review-Url: https://codereview.chromium.org/2751973009 Cr-Commit-Position: refs/heads/master@{#457908} Committed: https://chromium.googlesource.com/chromium/src/+/a5082d6ce45219eba13fae950a5f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a5082d6ce45219eba13fae950a5f... |