Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2751973009: Disable 4 PDFExtensionTest test cases as they fail on multiple bots. (Closed)

Created:
3 years, 9 months ago by krasin1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable 4 PDFExtensionTest test cases as they fail on multiple bots. BUG=701427 Review-Url: https://codereview.chromium.org/2751973009 Cr-Commit-Position: refs/heads/master@{#457908} Committed: https://chromium.googlesource.com/chromium/src/+/a5082d6ce45219eba13fae950a5fbdda07fe3442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
krasin1
3 years, 9 months ago (2017-03-17 20:42:43 UTC) #2
Lei Zhang
Do you want to disable only in official builds, or something like that rather than ...
3 years, 9 months ago (2017-03-17 21:36:14 UTC) #6
krasin1
On 2017/03/17 21:36:14, Lei Zhang (super slow) wrote: > Do you want to disable only ...
3 years, 9 months ago (2017-03-17 22:35:16 UTC) #10
Lei Zhang
lgtm I hope we'll just fix it soon.
3 years, 9 months ago (2017-03-17 22:36:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751973009/1
3 years, 9 months ago (2017-03-17 22:38:21 UTC) #16
Nico
On 2017/03/17 22:35:16, krasin1 wrote: > On 2017/03/17 21:36:14, Lei Zhang (super slow) wrote: > ...
3 years, 9 months ago (2017-03-17 22:44:26 UTC) #17
krasin1
On 2017/03/17 22:44:26, Nico wrote: > On 2017/03/17 22:35:16, krasin1 wrote: > > On 2017/03/17 ...
3 years, 9 months ago (2017-03-17 22:53:19 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 00:14:32 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a5082d6ce45219eba13fae950a5f...

Powered by Google App Engine
This is Rietveld 408576698