Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2751973004: Fixed permission check in SystemAccountManagerDelegate.updateCredentials (Closed)

Created:
3 years, 9 months ago by jlebel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fixed permission check in SystemAccountManagerDelegate.updateCredentials Checking hasGetAccountsPermission before calling android.AccountManager.updateCredentials is irrelevant, because this call never required GET_ACCOUNTS permission. Added check for MANAGE_ACCOUNTS permission that was required before Android M. On M+ it doesn't require any special permission. BUG=699050 Review-Url: https://codereview.chromium.org/2745533002 Cr-Commit-Position: refs/heads/master@{#456124} (cherry picked from commit 6e26494d0caa38a608ecd3c7852a58387dcaaf96) Review-Url: https://codereview.chromium.org/2751973004 . Cr-Commit-Position: refs/branch-heads/3029@{#235} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/9609fe5d7016961497955f2d59b691e84fb92402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java View 3 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jlebel
3 years, 9 months ago (2017-03-16 10:30:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9609fe5d7016961497955f2d59b691e84fb92402.

Powered by Google App Engine
This is Rietveld 408576698