Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2751953003: cc: Remove redundant BufferIdAllocator (Closed)

Created:
3 years, 9 months ago by Chandan
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove redundant BufferIdAllocator BufferIdAllocator was unnescessarily getting created in ResourceProvider's ctor as it was not being used anywhere. This commit removes IdAllocator/BufferIdAllocator class and its allocation. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2751953003 Cr-Commit-Position: refs/heads/master@{#457427} Committed: https://chromium.googlesource.com/chromium/src/+/ed1bb4a6435d6b8c65f99795bc16c90696b56282

Patch Set 1 #

Patch Set 2 : cc: Remove redundant BufferIdAllocator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -66 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/resource_provider.h View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/resources/resource_provider.cc View 4 chunks +24 lines, -63 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Chandan
PTAL!
3 years, 9 months ago (2017-03-15 11:59:42 UTC) #4
danakj
LGTM
3 years, 9 months ago (2017-03-15 14:58:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751953003/20001
3 years, 9 months ago (2017-03-16 13:31:17 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 14:23:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ed1bb4a6435d6b8c65f99795bc16...

Powered by Google App Engine
This is Rietveld 408576698