Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: extensions/browser/verified_contents.h

Issue 2751913009: Remove some VerifiedContents methods' params that are always false. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/content_hash_reader.cc ('k') | extensions/browser/verified_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/verified_contents.h
diff --git a/extensions/browser/verified_contents.h b/extensions/browser/verified_contents.h
index 38265e51ddb7ccd9aaded4729bfeddc3b1f1191a..9d0924a67ec1ddf2c972a545cf3a2124104895b8 100644
--- a/extensions/browser/verified_contents.h
+++ b/extensions/browser/verified_contents.h
@@ -29,10 +29,7 @@ class VerifiedContents {
// Returns true if we successfully parsed the verified_contents.json file at
// |path| and validated the enclosed signature. The
- // |ignore_invalid_signature| argument can be set to make this still succeed
- // if the contents of the file were parsed successfully but the signature did
- // not validate. (Use with caution!)
- bool InitFrom(const base::FilePath& path, bool ignore_invalid_signature);
+ bool InitFrom(const base::FilePath& path);
int block_size() const { return block_size_; }
const std::string& extension_id() const { return extension_id_; }
@@ -49,10 +46,8 @@ class VerifiedContents {
private:
// Returns the base64url-decoded "payload" field from the json at |path|, if
- // the signature was valid (or ignore_invalid_signature was set to true).
- bool GetPayload(const base::FilePath& path,
- std::string* payload,
- bool ignore_invalid_signature);
+ // the signature was valid.
+ bool GetPayload(const base::FilePath& path, std::string* payload);
// The |protected_value| and |payload| arguments should be base64url encoded
// strings, and |signature_bytes| should be a byte array. See comments in the
« no previous file with comments | « extensions/browser/content_hash_reader.cc ('k') | extensions/browser/verified_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698