Chromium Code Reviews
Help | Chromium Project | Sign in
(6)

Issue 2751913009: Remove some VerifiedContents methods' params that are always false. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by lazyboy
Modified:
6 days, 18 hours ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some VerifiedContents methods' params that are always false. BUG=None Test=None, internal cleanup. Review-Url: https://codereview.chromium.org/2751913009 Cr-Commit-Position: refs/heads/master@{#457947} Committed: https://chromium.googlesource.com/chromium/src/+/ee07b33227f7c3ff717f7845b281780ff1428264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M extensions/browser/content_hash_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/content_hash_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/verified_contents.h View 2 chunks +3 lines, -8 lines 0 comments Download
M extensions/browser/verified_contents.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M extensions/browser/verified_contents_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (8 generated)
lazyboy
6 days, 23 hours ago (2017-03-17 22:14:05 UTC) #4
Devlin
Nice! LGTM as long as bots are happy.
6 days, 23 hours ago (2017-03-17 22:23:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751913009/1
6 days, 19 hours ago (2017-03-18 02:39:21 UTC) #9
commit-bot: I haz the power
6 days, 18 hours ago (2017-03-18 03:15:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee07b33227f7c3ff717f7845b281...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62