Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 2751913008: [Mac] Resize bookmark bar no item container after localizing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by lgrey
Modified:
4 months, 1 week ago
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Resize bookmark bar no item container after localizing BUG=702287 Review-Url: https://codereview.chromium.org/2751913008 Cr-Commit-Position: refs/heads/master@{#458059} Committed: https://chromium.googlesource.com/chromium/src/+/e3146dac1c094489c1eba84a95f699f5b553ef32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm View 1 chunk +4 lines, -0 lines 0 comments Download
Trybot results:  linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   cast_shell_linux   android_clang_dbg_recipe   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   chromeos_daisy_chromium_compile_only_ng   mac_chromium_rel_ng   win_chromium_x64_rel_ng   linux_android_rel_ng   mac_chromium_compile_dbg_ng   android_n5x_swarming_rel   win_clang   ios-device   win_chromium_rel_ng   android_compile_dbg   linux_chromium_chromeos_ozone_rel_ng   chromium_presubmit   win_chromium_compile_dbg_ng   linux_chromium_asan_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   ios-device-xcode-clang   cast_shell_android   android_arm64_dbg_recipe   ios-simulator   android_cronet   ios-simulator-xcode-clang   win_chromium_rel_ng   mac_chromium_rel_ng   linux_chromium_compile_dbg_ng   win_chromium_compile_dbg_ng   win_clang   chromeos_daisy_chromium_compile_only_ng   linux_chromium_asan_rel_ng   android_compile_dbg   linux_chromium_rel_ng   linux_android_rel_ng   win_chromium_x64_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   mac_chromium_compile_dbg_ng   ios-device-xcode-clang   ios-simulator   android_n5x_swarming_rel   ios-simulator-xcode-clang   android_cronet   ios-device   cast_shell_android   linux_chromium_chromeos_rel_ng   android_arm64_dbg_recipe   cast_shell_linux   chromium_presubmit   mac_chromium_rel_ng   android_clang_dbg_recipe   linux_chromium_tsan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   win_chromium_rel_ng 
Commit queue not available (can’t edit this change).

Messages

Total messages: 13 (6 generated)
lgrey
PTAL :)
4 months, 1 week ago (2017-03-17 18:34:19 UTC) #2
Avi (ping after 24h)
lgtm
4 months, 1 week ago (2017-03-17 19:15:03 UTC) #3
lgrey
Thanks!
4 months, 1 week ago (2017-03-17 19:16:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751913008/1
4 months, 1 week ago (2017-03-17 19:17:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/409503)
4 months, 1 week ago (2017-03-17 22:31:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751913008/1
4 months, 1 week ago (2017-03-20 14:25:07 UTC) #10
commit-bot: I haz the power
4 months, 1 week ago (2017-03-20 14:46:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3146dac1c094489c1eba84a95f6...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973