Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_utils.h

Issue 2751913004: arc: Fix race conditon when Play Store is started too early. (Closed)
Patch Set: adressed Hidehiko's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/arc/arc_app_utils.h
diff --git a/chrome/browser/ui/app_list/arc/arc_app_utils.h b/chrome/browser/ui/app_list/arc/arc_app_utils.h
index e0911730bbfed73048e44dbf63badcb64068755f..b575af7d9b26fefb559848b50a35b1ab6bc446c2 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_utils.h
+++ b/chrome/browser/ui/app_list/arc/arc_app_utils.h
@@ -43,6 +43,8 @@ bool LaunchPlayStoreWithUrl(const std::string& url);
// Launch an app with given layout and let the system decides how big and where
// to place it.
+// TODO (khmel) Rename this method to reduce the chance of using another
hidehiko 2017/03/16 16:23:19 Nice comment! Or, maybe replacing "bool" for layo
khmel 2017/03/16 16:38:47 Nice alternative
+// LaunchApp with different signature mistakenly.
bool LaunchApp(content::BrowserContext* context,
const std::string& app_id,
bool landscape_layout,

Powered by Google App Engine
This is Rietveld 408576698