arc: Fix race conditon when Play Store is started too early.

chrome/browser/ui/app_list/arc/arc_app_utils.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_APP_LIST_ARC_ARC_APP_UTILS_H_
 #define CHROME_BROWSER_UI_APP_LIST_ARC_ARC_APP_UTILS_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 25 matching lines @@
 
 // Launch Android Settings app.
 bool LaunchAndroidSettingsApp(content::BrowserContext* context,
                               int event_flags);
 
 // Launch Play Store app.
 bool LaunchPlayStoreWithUrl(const std::string& url);
 
 // Launch an app with given layout and let the system decides how big and where
 // to place it.
+// TODO (khmel) Rename this method to reduce the chance of using another

[hidehiko, 2017/03/16 16:23:19]

Nice comment!

Or, maybe replacing "bool" for layout with enum class, so that implicit
conversion won't be triggered.

enum class Layout {
  PORTRAIT,
  LANDSCAPE,
};

bool LaunchApp(content::BrowserContext* context,
               const std::string& app_id,
               Layout layout,
               int event_flags);

Note: not necessary to address it in this CL, I think.

[khmel, 2017/03/16 16:38:47]

Nice alternative

+// LaunchApp with different signature mistakenly.
 bool LaunchApp(content::BrowserContext* context,
                const std::string& app_id,
                bool landscape_layout,
                int event_flags);
 
 // Launch an app and place it at the specified coordinates.
 bool LaunchAppWithRect(content::BrowserContext* context,
                        const std::string& app_id,
                        const gfx::Rect& target_rect,
                        int event_flags);
@@ skipping 32 matching lines @@
 // Shows package info for ARC package at the specified page.
 bool ShowPackageInfoOnPage(const std::string& package_name,
                            mojom::ShowPackageInfoPage page);
 
 // Returns true if |id| represents either ARC app or ARC shelf group.
 bool IsArcItem(content::BrowserContext* context, const std::string& id);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_UI_APP_LIST_ARC_ARC_APP_UTILS_H_