Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5571)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

Issue 2751913003: Add metrics to track Google Play install WebAPK failures. (Closed)
Patch Set: Nits. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
index 5523f9283e1794f30c787d7516d0d98bb8c48d8f..e981b0b474f57ebd9173543776a1352682d5176a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
@@ -20,6 +20,7 @@ import org.chromium.base.annotations.CalledByNative;
import org.chromium.chrome.browser.AppHooks;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.banners.InstallerDelegate;
+import org.chromium.chrome.browser.metrics.WebApkUma;
import org.chromium.chrome.browser.util.IntentUtils;
import java.io.File;
@@ -109,6 +110,8 @@ public class WebApkInstaller {
String packageName, int version, String title, String token, String url) {
if (mGooglePlayWebApkInstallDelegate == null) {
notify(WebApkInstallResult.FAILURE);
+ WebApkUma.recordGooglePlayIntallResult(
dominickn 2017/03/22 00:15:22 Should this conditional be moved after the isWebAp
Xi Han 2017/03/22 17:32:36 It makes sense to me. Yes, we shouldn't records an
+ WebApkUma.GOOGLE_PLAY_INSTALL_FAILED_NO_DELEGATE);
return;
}

Powered by Google App Engine
This is Rietveld 408576698