Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2751913003: Add metrics to track Google Play install WebAPK failures. (Closed)

Created:
3 years, 9 months ago by Xi Han
Modified:
3 years, 8 months ago
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metrics to track Google Play install WebAPK failures. We introduce new metric "WebApk.Install.GooglePlayInstallResult" to track whether installing WebAPKs from Google Play succeeded, and if not the reason of failures provided by Google Play. The internal CL to record this metric is: https://chrome-internal-review.googlesource.com/c/337268/ BUG=701497 Review-Url: https://codereview.chromium.org/2751913003 Cr-Commit-Position: refs/heads/master@{#460123} Committed: https://chromium.googlesource.com/chromium/src/+/14d62f4baa9f21faf511b3f52d65a36d18fe3aad

Patch Set 1 #

Patch Set 2 : pkotwicz@'s comments. #

Total comments: 12

Patch Set 3 : Nits. #

Total comments: 4

Patch Set 4 : dominickn@'s comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java View 1 2 3 3 chunks +8 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
Xi Han
Hi Peter, could you please take a look? Thanks!
3 years, 9 months ago (2017-03-16 20:00:24 UTC) #3
pkotwicz
Added a comment to the internal CL which affects this one I think
3 years, 9 months ago (2017-03-17 15:52:24 UTC) #5
Xi Han
PTAL, thanks!
3 years, 9 months ago (2017-03-17 19:55:22 UTC) #8
pkotwicz
LGTM with nits https://codereview.chromium.org/2751913003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java File chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java (right): https://codereview.chromium.org/2751913003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java#newcode86 chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java:86: * failures sent by Google Play. ...
3 years, 9 months ago (2017-03-21 16:59:40 UTC) #9
Xi Han
Hi Dom, could you please take a look? Thanks! https://codereview.chromium.org/2751913003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java File chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java (right): https://codereview.chromium.org/2751913003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java#newcode86 chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java:86: ...
3 years, 9 months ago (2017-03-21 18:43:46 UTC) #11
dominickn
https://codereview.chromium.org/2751913003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java File chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java (right): https://codereview.chromium.org/2751913003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java#newcode85 chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java:85: public static void recordGooglePlayIntallResult(int result) { "Install" (not "Intall") ...
3 years, 9 months ago (2017-03-22 00:15:22 UTC) #12
Xi Han
PTAL, thanks! https://codereview.chromium.org/2751913003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java File chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java (right): https://codereview.chromium.org/2751913003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java#newcode85 chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java:85: public static void recordGooglePlayIntallResult(int result) { On ...
3 years, 9 months ago (2017-03-22 17:32:36 UTC) #13
dominickn
lgtm, thanks
3 years, 9 months ago (2017-03-22 23:22:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751913003/80001
3 years, 9 months ago (2017-03-27 13:47:42 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/395255)
3 years, 9 months ago (2017-03-27 13:55:11 UTC) #19
Xi Han
+dfalcantara@: Please review: - chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java +isherman@: Please review: - tools/metrics/histograms/histograms.xml Thank you both!
3 years, 9 months ago (2017-03-27 13:57:07 UTC) #21
Ilya Sherman
Metrics LGTM, thanks.
3 years, 9 months ago (2017-03-27 15:27:49 UTC) #22
gone
lgtm
3 years, 9 months ago (2017-03-27 21:33:54 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751913003/80001
3 years, 8 months ago (2017-03-28 13:28:45 UTC) #25
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 16:31:48 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/14d62f4baa9f21faf511b3f52d65...

Powered by Google App Engine
This is Rietveld 408576698