Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

Issue 2751913003: Add metrics to track Google Play install WebAPK failures. (Closed)
Patch Set: pkotwicz@'s comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
index 1a00ca78e900b4506f2ca7de173ee519b36bf070..e981b0b474f57ebd9173543776a1352682d5176a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
@@ -20,6 +20,7 @@ import org.chromium.base.annotations.CalledByNative;
import org.chromium.chrome.browser.AppHooks;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.banners.InstallerDelegate;
+import org.chromium.chrome.browser.metrics.WebApkUma;
import org.chromium.chrome.browser.util.IntentUtils;
import java.io.File;
@@ -109,6 +110,8 @@ public class WebApkInstaller {
String packageName, int version, String title, String token, String url) {
if (mGooglePlayWebApkInstallDelegate == null) {
notify(WebApkInstallResult.FAILURE);
+ WebApkUma.recordGooglePlayIntallResult(
+ WebApkUma.GOOGLE_PLAY_INSTALL_FAILED_NO_DELEGATE);
return;
}
@@ -183,7 +186,7 @@ public class WebApkInstaller {
WebApkInstaller.this.notify(result);
}
};
- mGooglePlayWebApkInstallDelegate.installAsync(
+ mGooglePlayWebApkInstallDelegate.updateAsync(
packageName, version, title, token, url, callback);
}

Powered by Google App Engine
This is Rietveld 408576698