Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2751903004: [Cleanup] Document the CrashFileManager state machine. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by Ilya Sherman
Modified:
3 months, 1 week ago
Reviewers:
gsennton
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Document the CrashFileManager state machine. BUG=none TEST=none R=gsennton@chromium.org Review-Url: https://codereview.chromium.org/2751903004 Cr-Commit-Position: refs/heads/master@{#458153} Committed: https://chromium.googlesource.com/chromium/src/+/3799bf204600f04680a4925073038516fec75035

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove misleading Webview notes #

Messages

Total messages: 13 (8 generated)
Ilya Sherman
3 months, 1 week ago (2017-03-16 02:09:56 UTC) #1
gsennton
Nice! Thanks Ilya :) I have a couple of minor comments (not sure if there ...
3 months, 1 week ago (2017-03-20 17:18:02 UTC) #6
Ilya Sherman
Thanks for the clarifications! =) https://codereview.chromium.org/2751903004/diff/1/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java File components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java (right): https://codereview.chromium.org/2751903004/diff/1/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java#newcode38 components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java:38: * the filename. Notably, ...
3 months, 1 week ago (2017-03-20 18:14:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751903004/20001
3 months, 1 week ago (2017-03-20 18:15:33 UTC) #10
commit-bot: I haz the power
3 months, 1 week ago (2017-03-20 19:45:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3799bf204600f04680a492507303...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318