[Android Crash Reporting] Correct the regex for uploaded minidump filenames.

[Android Crash Reporting] Correct the regex for uploaded minidump filenames.

BUG=701615
TEST=CrashFileManagerTest
R=gsennton@chromium.org, mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2751903002
Cr-Commit-Position: refs/heads/master@{#457105}
Committed: https://chromium.googlesource.com/chromium/src/+/3e31d9cc1a969da3159fc3ac132c4353a32c281d

[Ilya Sherman, 2017-03-15 00:43:22]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 00:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 02:11:48]

Dry run: This issue passed the CQ dry run.

[Maria, 2017-03-15 04:40:54]

lgtm

I think it's important to figure out when this got broken, so we know how many
versions may have been affected by this (e.g. in case we see changes in rates of
crashes reported because of this)

[Ilya Sherman, 2017-03-15 07:25:13]

On 2017/03/15 04:40:54, Maria wrote:
> lgtm
> 
> I think it's important to figure out when this got broken, so we know how many
> versions may have been affected by this (e.g. in case we see changes in rates
of
> crashes reported because of this)

I looked back through code history, and AFAICT, it's been broken since before I
ever started working on this code, which was several versions ago.  I'm guessing
it's been broken for quite a long time... and for Chrome, I wouldn't expect it
to have much effect on the number of crashes that are reported, because the only
limitation this imposes is a slight bump to total disk utilization on the device
-- Chrome doesn't really enforce a limit on how many crashes we keep around (at
least, not that I'm aware of).

[gsennton, 2017-03-15 10:18:49]

lgtm, thanks a bunch Ilya!
Would you mind merging this to 58 as well? :)

https://codereview.chromium.org/2751903002/diff/1/components/minidump_uploade...
File
components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java
(left):

https://codereview.chromium.org/2751903002/diff/1/components/minidump_uploade...
components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java:567:
File recentFailedUpload = new File(mCrashDir, prefix + ".up0.try0");
It's slightly amusing that we had a test case ensuring that this was Not working
correctly ;)

[Ilya Sherman, 2017-03-15 16:32:01]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-03-15 16:32:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-03-15 16:32:57]

https://codereview.chromium.org/2751903002/diff/1/components/minidump_uploade...
File
components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java
(left):

https://codereview.chromium.org/2751903002/diff/1/components/minidump_uploade...
components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java:567:
File recentFailedUpload = new File(mCrashDir, prefix + ".up0.try0");
On 2017/03/15 10:18:49, gsennton_OOO_Mar16-17 wrote:
> It's slightly amusing that we had a test case ensuring that this was Not
working
> correctly ;)

... yeah, I was clearly pretty confused by the intended state machine when I
first started working on this code =P

[commit-bot: I haz the power, 2017-03-15 16:37:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489595521972740, "parent_rev":
"d8336c52ff1f0d377be83df3d3eef2cdb5573c25", "commit_rev":
"3e31d9cc1a969da3159fc3ac132c4353a32c281d"}

[commit-bot: I haz the power, 2017-03-15 16:38:47]

Description was changed from

==========
[Android Crash Reporting] Correct the regex for uploaded minidump filenames.

BUG=701615
TEST=CrashFileManagerTest
R=gsennton@chromium.org, mariakhomenko@chromium.org
==========

to

==========
[Android Crash Reporting] Correct the regex for uploaded minidump filenames.

BUG=701615
TEST=CrashFileManagerTest
R=gsennton@chromium.org, mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2751903002
Cr-Commit-Position: refs/heads/master@{#457105}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e31d9cc1a969da3159fc3ac132c...
==========

[commit-bot: I haz the power, 2017-03-15 16:38:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e31d9cc1a969da3159fc3ac132c...