Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2751883004: Merge M58: Revert "Make Crashpad start asynchronous, and move back to chrome_elf" (Closed)

Created:
3 years, 9 months ago by Will Harris
Modified:
3 years, 9 months ago
CC:
chromium-reviews, sadrul, jam, pennymac+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, caitkp+watch_chromium.org, kalyank
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge M58: Revert "Make Crashpad start asynchronous, and move back to chrome_elf" This reverts commit be0cfa14d77c72864a74d2bcc7910b0b31b7eecb. See linked bug for details. R=mark@chromium.org, grt@chromium.org, thestig@chromium.org BUG=700371 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2736393005 Cr-Commit-Position: refs/branch-heads/2987@{#816} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} (cherry picked from commit 24b232ed824889b3b14b462a389fb42fcaa50b67) Review-Url: https://codereview.chromium.org/2751883004 . Cr-Commit-Position: refs/branch-heads/3029@{#211} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5cd5ecf81546468f888891a354027bd9689ee0f2

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -55 lines) Patch
M chrome/app/chrome_exe_main_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome_elf/chrome_elf.def View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_elf/chrome_elf_main.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_elf/chrome_elf_main.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M components/crash/content/app/crashpad.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/crash/content/app/crashpad.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/crash/content/app/crashpad_win.cc View 2 chunks +3 lines, -19 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Will Harris
mark@ - Since I'm merging a revert to code I'm not 100% familiar with, can ...
3 years, 9 months ago (2017-03-15 18:14:14 UTC) #1
Mark Mentovai
LGTM
3 years, 9 months ago (2017-03-15 18:32:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751883004/1
3 years, 9 months ago (2017-03-15 18:33:20 UTC) #4
commit-bot: I haz the power
Failed to commit the patch.
3 years, 9 months ago (2017-03-15 18:48:45 UTC) #9
Will Harris
On 2017/03/15 18:48:45, commit-bot: I haz the power wrote: > Failed to commit the patch. ...
3 years, 9 months ago (2017-03-15 18:50:49 UTC) #10
Will Harris
Committed patchset #2 (id:20001) manually as 5cd5ecf81546468f888891a354027bd9689ee0f2.
3 years, 9 months ago (2017-03-15 18:53:26 UTC) #12
grt (UTC plus 2)
3 years, 9 months ago (2017-03-16 08:10:54 UTC) #13
Message was sent while issue was closed.
rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698