Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2751853003: Use std::atomic instead of atopmicops.h in PartitionAlloc. (Closed)

Created:
3 years, 9 months ago by palmer
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
Mads Ager (chromium), chromium-reviews, Dai Mikurube (NOT FULLTIME), kouhei+heap_chromium.org, oilpan-reviews, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::atomic instead of atopmicops.h in PartitionAlloc. This results in 1 less dependency for PA. BUG=695274 Review-Url: https://codereview.chromium.org/2751853003 Cr-Commit-Position: refs/heads/master@{#457112} Committed: https://chromium.googlesource.com/chromium/src/+/c2101d04be0e3da816f47164e8c5120aaea90e27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M base/allocator/partition_allocator/page_allocator.cc View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
palmer
PTAL. Hopefully simple, hopefully I'm doing it right. :)
3 years, 9 months ago (2017-03-15 03:28:40 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-15 07:30:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751853003/1
3 years, 9 months ago (2017-03-15 16:33:18 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 17:12:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2101d04be0e3da816f47164e8c5...

Powered by Google App Engine
This is Rietveld 408576698