Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2751833011: Add url to BIDIRECTIONAL_STREAM events in NetLog UI (Closed)

Created:
3 years, 9 months ago by xunjieli
Modified:
3 years, 9 months ago
Reviewers:
eroman
CC:
chromium-reviews, bnc+watch_chromium.org, arv+watch_chromium.org, mmenke, eroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add url to BIDIRECTIONAL_STREAM events in NetLog UI This CL adds a url next to a BIDIRECTIONAL_STREAM event. BUG=701834 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751833011 Cr-Commit-Position: refs/heads/master@{#457259} Committed: https://chromium.googlesource.com/chromium/src/+/41e679963507c262751fdf59c83337b874395bac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/net_internals/source_entry.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
xunjieli
Eric: PTAL. An example netlog dump is at https://drive.google.com/a/google.com/file/d/0B_9WseIqRoaFOWU0RmZPWndwSEE/view?usp=sharing (only shared internally because the dump ...
3 years, 9 months ago (2017-03-15 21:56:28 UTC) #3
eroman
lgtm
3 years, 9 months ago (2017-03-15 21:57:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751833011/1
3 years, 9 months ago (2017-03-15 21:58:53 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 23:20:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/41e679963507c262751fdf59c833...

Powered by Google App Engine
This is Rietveld 408576698