Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2751813002: DevTools: Clean up character diff (Closed)

Created:
3 years, 9 months ago by einbinder
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Clean up character diff diff_match_patch has the ability to clean up diffs, removing small changes that are likely coincidental. BUG=610061 Review-Url: https://codereview.chromium.org/2751813002 Cr-Commit-Position: refs/heads/master@{#456884} Committed: https://chromium.googlesource.com/chromium/src/+/229324e62cfbaf5b941d738697ff84fd1396b382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/diff/Diff.js View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
einbinder
ptal
3 years, 9 months ago (2017-03-14 21:03:34 UTC) #2
lushnikov
lgtm
3 years, 9 months ago (2017-03-14 21:45:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751813002/1
3 years, 9 months ago (2017-03-14 21:47:39 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 23:20:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/229324e62cfbaf5b941d738697ff...

Powered by Google App Engine
This is Rietveld 408576698