Compile folder_shotcuts_data_model in gyp v2.

Compile folder_shotcuts_data_model in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2751763004
Cr-Commit-Position: refs/heads/master@{#457451}
Committed: https://chromium.googlesource.com/chromium/src/+/a50545b9d3795b3902d9e0b12f0a30b94078a3b9

[oka, 2017-03-15 13:17:21]

Description was changed from

==========
Compile folder_shotcuts_data_model in gyp v2.

BUG=636289
==========

to

==========
Compile folder_shotcuts_data_model in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-03-15 13:18:05]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2017-03-15 13:18:06]

PTAL.

[fukino, 2017-03-15 13:53:39]

lgtm with nits. Thanks!

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp (right):

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:12: #       
'actions_model',
sort

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:22: #       
'folder_shortcuts_data_model',
ditto

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:79: #       
'../../common/js/compiled_resources2.gyp:util',
ditto

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:101:
'../../common/js/compiled_resources2.gyp:async_util',
ditto

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:238: #       
'ui/compiled_resources2.gyp:location_line',
ditto

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp:111:
'../../../../externs/compiled_resources2.gyp:volume_manager',
ditto

[oka, 2017-03-16 15:30:13]

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp (right):

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:12: #       
'actions_model',
On 2017/03/15 13:53:39, fukino wrote:
> sort

Done.

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:22: #       
'folder_shortcuts_data_model',
On 2017/03/15 13:53:39, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:79: #       
'../../common/js/compiled_resources2.gyp:util',
On 2017/03/15 13:53:39, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:101:
'../../common/js/compiled_resources2.gyp:async_util',
On 2017/03/15 13:53:39, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:238: #       
'ui/compiled_resources2.gyp:location_line',
On 2017/03/15 13:53:39, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2751763004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp:111:
'../../../../externs/compiled_resources2.gyp:volume_manager',
On 2017/03/15 13:53:39, fukino wrote:
> ditto

Done.

[oka, 2017-03-16 15:30:16]

The CQ bit was checked by oka@chromium.org

[oka, 2017-03-16 15:30:16]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2751763004/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-03-16 15:30:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 16:05:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489678216288400,
"parent_rev": "d757cae1fb34145830714904a7cb83e5ac4b840c", "commit_rev":
"a50545b9d3795b3902d9e0b12f0a30b94078a3b9"}

[commit-bot: I haz the power, 2017-03-16 16:06:12]

Description was changed from

==========
Compile folder_shotcuts_data_model in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile folder_shotcuts_data_model in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2751763004
Cr-Commit-Position: refs/heads/master@{#457451}
Committed:
https://chromium.googlesource.com/chromium/src/+/a50545b9d3795b3902d9e0b12f0a...
==========

[commit-bot: I haz the power, 2017-03-16 16:06:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a50545b9d3795b3902d9e0b12f0a...