Make USE_EXTERNAL_POPUP_MENU local to content.

Make USE_EXTERNAL_POPUP_MENU local to content.

No intended behavior change. -DUSE_EXTERNAL_POPUP should no longer be
on every single compiler invocation, but only on the ones that need it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2751763002
Cr-Commit-Position: refs/heads/master@{#457057}
Committed: https://chromium.googlesource.com/chromium/src/+/18e4264101591745752da096923f3133e6fc21e4

[Nico, 2017-03-14 17:47:23]

Description was changed from

==========
Make USE_EXTERNAL_POPUP_MENU local to content.

No intended behavior change. -DUSE_EXTERNAL_POPUP should no longer be
on every single compiler invocation, but only on the ones that need it.

BUG=none
==========

to

==========
Make USE_EXTERNAL_POPUP_MENU local to content.

No intended behavior change. -DUSE_EXTERNAL_POPUP should no longer be
on every single compiler invocation, but only on the ones that need it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Nico, 2017-03-14 17:47:44]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 17:48:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-14 17:54:20]

thakis@chromium.org changed reviewers:
+ avi@chromium.org

[Nico, 2017-03-14 17:54:20]

content/common/features.gni and content/common/BUILD.gn are interesting (and
short), the rest is mechanical.

[Avi (use Gerrit), 2017-03-14 19:47:08]

LGTM

[Nico, 2017-03-14 19:52:33]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-14 19:53:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 19:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 19:57:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nico, 2017-03-14 22:20:29]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-14 22:20:30]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2751763002/#ps40001
(title: "mojo typemap")

[commit-bot: I haz the power, 2017-03-14 22:21:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 22:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 22:35:43]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-03-14 23:18:56]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nico, 2017-03-14 23:18:57]

dcheng: SECURITY_OWNERS for:
    content/common/frame_messages.h
    content/common/native_types.typemap

[dcheng, 2017-03-15 00:51:59]

On 2017/03/14 23:18:57, Nico wrote:
> dcheng: SECURITY_OWNERS for:
>     content/common/frame_messages.h
>     content/common/native_types.typemap

LGTM

It feels pretty surprising that features is in the deps for the mojo typemaps,
since mojom files don't even support conditional compilation yet... But I guess
that's just how it is.

[dcheng, 2017-03-15 00:52:13]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:53:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 02:34:57]

Failed to apply patch for build/config/features.gni:
While running git apply --index -p1;
  error: patch failed: build/config/features.gni:67
  error: build/config/features.gni: patch does not apply

Patch:       build/config/features.gni
Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index
dee4632a13d8cde30c53709304723214624e977f..b4929213832524c89b8f06048ec53f8bad95ecbe
100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -67,9 +67,6 @@ declare_args() {
   use_gconf = is_linux && !is_chromeos && !is_chromecast
 
   use_gio = is_linux && !is_chromeos && !is_chromecast
-
-  # Whether or not to use external popup menu.
-  use_external_popup_menu = is_android || is_mac
 }
 
 # Additional dependent variables
-----------------------------------------------

[Nico, 2017-03-15 10:56:21]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-15 10:56:21]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2751763002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-15 10:56:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 12:06:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489575381572070,
"parent_rev": "15e3d9216e921042d06c0b6aaadcea10101d1034", "commit_rev":
"18e4264101591745752da096923f3133e6fc21e4"}

[commit-bot: I haz the power, 2017-03-15 12:07:26]

Description was changed from

==========
Make USE_EXTERNAL_POPUP_MENU local to content.

No intended behavior change. -DUSE_EXTERNAL_POPUP should no longer be
on every single compiler invocation, but only on the ones that need it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Make USE_EXTERNAL_POPUP_MENU local to content.

No intended behavior change. -DUSE_EXTERNAL_POPUP should no longer be
on every single compiler invocation, but only on the ones that need it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2751763002
Cr-Commit-Position: refs/heads/master@{#457057}
Committed:
https://chromium.googlesource.com/chromium/src/+/18e4264101591745752da096923f...
==========

[commit-bot: I haz the power, 2017-03-15 12:07:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/18e4264101591745752da096923f...