Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2751713002: Fetch Suggestions by category (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetch Suggestions by category This CL changes the behavior of the ContentSuggestions fetching. Instead of throwing away all the suggestions and reloading the new ones, the data sink only loads new suggestions if they are in an empty category. BUG=699124 Review-Url: https://codereview.chromium.org/2751713002 Cr-Commit-Position: refs/heads/master@{#456725} Committed: https://chromium.googlesource.com/chromium/src/+/8401d78afcd1cf80cbe547f597b3bad9edf83694

Patch Set 1 #

Patch Set 2 : Add comment #

Total comments: 6

Patch Set 3 : git cl web #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -48 lines) Patch
M ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm View 1 4 chunks +30 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 1 3 chunks +47 lines, -29 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h View 1 2 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-14 15:07:55 UTC) #2
stkhapugin
lgtm with comment about mutable array https://codereview.chromium.org/2751713002/diff/20001/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm (right): https://codereview.chromium.org/2751713002/diff/20001/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm#newcode256 ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:256: toArray:(NSMutableArray<ContentSuggestion*>*)contentArray { I ...
3 years, 9 months ago (2017-03-14 15:25:12 UTC) #3
gambard
Thanks! https://codereview.chromium.org/2751713002/diff/20001/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm (right): https://codereview.chromium.org/2751713002/diff/20001/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm#newcode256 ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:256: toArray:(NSMutableArray<ContentSuggestion*>*)contentArray { On 2017/03/14 15:25:12, stkhapugin wrote: > ...
3 years, 9 months ago (2017-03-14 16:05:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751713002/40001
3 years, 9 months ago (2017-03-14 16:06:24 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 16:27:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8401d78afcd1cf80cbe547f597b3...

Powered by Google App Engine
This is Rietveld 408576698