Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2751693003: chromeos: Migrate window rotation accelerator to common (Closed)

Created:
3 years, 9 months ago by James Cook
Modified:
3 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Migrate window rotation accelerator to common Now that we have aura-mus this doesn't need to live in the special aura-only accelerator delegate. BUG=701536 Review-Url: https://codereview.chromium.org/2751693003 Cr-Commit-Position: refs/heads/master@{#456967} Committed: https://chromium.googlesource.com/chromium/src/+/3a1f43df74a65967e3adbc9dd2a6fdd75a52fb7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M ash/accelerators/accelerator_controller_delegate_aura.cc View 5 chunks +0 lines, -27 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 5 chunks +26 lines, -0 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_delegate_mus.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
James Cook
msw, please take a look.
3 years, 9 months ago (2017-03-14 23:42:56 UTC) #2
msw
lgtm
3 years, 9 months ago (2017-03-15 00:12:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751693003/1
3 years, 9 months ago (2017-03-15 02:33:19 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 02:49:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3a1f43df74a65967e3adbc9dd2a6...

Powered by Google App Engine
This is Rietveld 408576698