Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2751673002: Don't run certificate algorithm mismatch tests on Sierra or later. (Closed)

Created:
3 years, 9 months ago by mattm
Modified:
3 years, 9 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't run certificate algorithm mismatch tests on Sierra or later. BUG=701222 Review-Url: https://codereview.chromium.org/2751673002 Cr-Commit-Position: refs/heads/master@{#456637} Committed: https://chromium.googlesource.com/chromium/src/+/d1b118ac1850cac95fa820722e227d7f7063cfdc

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M net/cert/cert_verify_proc_unittest.cc View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 13 (8 generated)
mattm
3 years, 9 months ago (2017-03-14 02:44:43 UTC) #4
eroman
lgtm Thanks! https://codereview.chromium.org/2751673002/diff/1/net/cert/cert_verify_proc_unittest.cc File net/cert/cert_verify_proc_unittest.cc (right): https://codereview.chromium.org/2751673002/diff/1/net/cert/cert_verify_proc_unittest.cc#newcode645 net/cert/cert_verify_proc_unittest.cc:645: // On iOS trying to import a ...
3 years, 9 months ago (2017-03-14 06:35:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751673002/1
3 years, 9 months ago (2017-03-14 06:36:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d1b118ac1850cac95fa820722e227d7f7063cfdc
3 years, 9 months ago (2017-03-14 06:40:57 UTC) #12
eroman
3 years, 9 months ago (2017-03-14 07:15:55 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2751673002/diff/1/net/cert/cert_verify_proc_u...
File net/cert/cert_verify_proc_unittest.cc (right):

https://codereview.chromium.org/2751673002/diff/1/net/cert/cert_verify_proc_u...
net/cert/cert_verify_proc_unittest.cc:645: // On iOS trying to import a
certificate with mismatched signature will
On 2017/03/14 06:35:02, eroman wrote:
> Can you update this comment?

(FTR, I checked the commit box before you could respond to this comment)

Powered by Google App Engine
This is Rietveld 408576698