Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2751663002:
Safe audio video checker: create mojo client with MakeUnique<> (Closed)
|
Created:
3 years, 9 months ago by Noel Gordon Modified:
3 years, 9 months ago CC:
chromium-reviews, tommycli, posciak+watch_chromium.org, tzik, nhiroki, Lei Zhang, kinuko+fileapi Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSafe audio video checker: create mojo client with MakeUnique<>
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
TBR=tommycli@chromium.org
BUG=680928
Review-Url: https://codereview.chromium.org/2751663002
Cr-Commit-Position: refs/heads/master@{#456912}
Committed: https://chromium.googlesource.com/chromium/src/+/c4a2fb2a5af868924d3282721757194ded52374d
Patch Set 1 #
Messages
Total messages: 21 (16 generated)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
noel@chromium.org changed reviewers: + sammc@chromium.org, thestig@chromium.org
thestig@, mentioned using MakeUnique here, which is what we do now [1]. Update this older code to match. [1] https://codereview.chromium.org/2644313002/#msg45
Description was changed from
==========
SafeAudioVideoChecker: MakeUnique UtilityProcessMojoClient
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
BUG=680928
==========
to
==========
SafeAudioVideoChecker: MakeUnique UtilityProcessMojoClient
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
BUG=680928
==========
noel@chromium.org changed reviewers: + tommycli@chromium.org
lgtm
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
SafeAudioVideoChecker: MakeUnique UtilityProcessMojoClient
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
BUG=680928
==========
to
==========
Safe audio video checker: MakeUnique UtilityProcessMojoClient
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
BUG=680928
==========
Description was changed from
==========
Safe audio video checker: MakeUnique UtilityProcessMojoClient
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
BUG=680928
==========
to
==========
Safe audio video checker: create mojo client with MakeUnique<>
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
BUG=680928
==========
Description was changed from
==========
Safe audio video checker: create mojo client with MakeUnique<>
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
BUG=680928
==========
to
==========
Safe audio video checker: create mojo client with MakeUnique<>
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
TBR=tommycli@chromium.org
BUG=680928
==========
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Safe audio video checker: create mojo client with MakeUnique<>
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.{ValidVideo,
ValidAudio}.
TBR=tommycli@chromium.org
BUG=680928
==========
to
==========
Safe audio video checker: create mojo client with MakeUnique<>
Update to use the current UtilityProcessMojoClient pattern we
have settled on for creating these mojo utility clients:
base::MakeUnique<UtilityMojoClient<Interface>>(process_name).
Covered by browsertests MediaFileValidatorTest.ValidAudio.
TBR=tommycli@chromium.org
BUG=680928
==========
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489537055564790, "parent_rev":
"4e69ce94a064f6ed38ed65c89e41437ac4932723", "commit_rev":
"c4a2fb2a5af868924d3282721757194ded52374d"}
Description was changed from ========== Safe audio video checker: create mojo client with MakeUnique<> Update to use the current UtilityProcessMojoClient pattern we have settled on for creating these mojo utility clients: base::MakeUnique<UtilityMojoClient<Interface>>(process_name). Covered by browsertests MediaFileValidatorTest.ValidAudio. TBR=tommycli@chromium.org BUG=680928 ========== to ========== Safe audio video checker: create mojo client with MakeUnique<> Update to use the current UtilityProcessMojoClient pattern we have settled on for creating these mojo utility clients: base::MakeUnique<UtilityMojoClient<Interface>>(process_name). Covered by MediaFileValidatorTest.ValidAudio. TBR=tommycli@chromium.org BUG=680928 ==========
Description was changed from ========== Safe audio video checker: create mojo client with MakeUnique<> Update to use the current UtilityProcessMojoClient pattern we have settled on for creating these mojo utility clients: base::MakeUnique<UtilityMojoClient<Interface>>(process_name). Covered by MediaFileValidatorTest.ValidAudio. TBR=tommycli@chromium.org BUG=680928 ========== to ========== Safe audio video checker: create mojo client with MakeUnique<> Update to use the current UtilityProcessMojoClient pattern we have settled on for creating these mojo utility clients: base::MakeUnique<UtilityMojoClient<Interface>>(process_name). Covered by MediaFileValidatorTest.ValidAudio. TBR=tommycli@chromium.org BUG=680928 ==========
Message was sent while issue was closed.
Description was changed from ========== Safe audio video checker: create mojo client with MakeUnique<> Update to use the current UtilityProcessMojoClient pattern we have settled on for creating these mojo utility clients: base::MakeUnique<UtilityMojoClient<Interface>>(process_name). Covered by MediaFileValidatorTest.ValidAudio. TBR=tommycli@chromium.org BUG=680928 ========== to ========== Safe audio video checker: create mojo client with MakeUnique<> Update to use the current UtilityProcessMojoClient pattern we have settled on for creating these mojo utility clients: base::MakeUnique<UtilityMojoClient<Interface>>(process_name). Covered by browsertests MediaFileValidatorTest.{ValidVideo, ValidAudio}. TBR=tommycli@chromium.org BUG=680928 Review-Url: https://codereview.chromium.org/2751663002 Cr-Commit-Position: refs/heads/master@{#456912} Committed: https://chromium.googlesource.com/chromium/src/+/c4a2fb2a5af868924d3282721757... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c4a2fb2a5af868924d3282721757... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
