Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2751653009: exo: Clean up display configuration protocol (Closed)

Created:
3 years, 9 months ago by Dominik Laskowski
Modified:
3 years, 9 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Clean up display configuration protocol The fact that the client only uses the transform and scale factor of the primary display is an implementation detail, so the protocol was changed to include this information for each display. The new protocol also does away with the primary display ID, which can be deduced using the display bounds now that screen coordinates are used. BUG=642894 TEST=None Review-Url: https://codereview.chromium.org/2751653009 Cr-Commit-Position: refs/heads/master@{#457595} Committed: https://chromium.googlesource.com/chromium/src/+/5f68bcb19b832bb425469aa7e1a362e9a0326181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M components/exo/wayland/server.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Dominik Laskowski
PTAL.
3 years, 9 months ago (2017-03-16 20:45:26 UTC) #4
reveman
lgtm assuming we haven't actually started using this protocol on the client side yet
3 years, 9 months ago (2017-03-16 22:36:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751653009/1
3 years, 9 months ago (2017-03-16 22:56:29 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 23:04:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f68bcb19b832bb425469aa7e1a3...

Powered by Google App Engine
This is Rietveld 408576698