Replace ASSERT and ASSERT_NOT_REACHED in core/style/

Replace  ASSERT and  ASSERT_NOT_REACHED in core/style/

Replacing ASSERT and ASSERT_NOT_REACHED in core/style/
with DCHECK_op, NOTREACHED respectively.

BUG=697688
Review-Url: https://codereview.chromium.org/2751653003
Cr-Commit-Position: refs/heads/master@{#457437}
Committed: https://chromium.googlesource.com/chromium/src/+/8ef33b2cfea95309080e9d7f452233e0e780d5d8

[nikhil.sahni, 2017-03-14 04:57:26]

Description was changed from

==========
Replace  ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/

Replacing ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/
with DCHECK_op, NOTREACHED, CHECK_op respectively.

BUG=697688
==========

to

==========
Replace  ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/

Replacing ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/
with DCHECK_op, NOTREACHED, CHECK_op respectively.

BUG=697688

R=SamsungPeerReview
==========

[nikhil.sahni, 2017-03-14 04:57:26]

Description was changed from

==========
Replace  ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/

Replacing ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/
with DCHECK_op, NOTREACHED, CHECK_op respectively.

BUG=697688
==========

to

==========
Replace  ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/

Replacing ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/
with DCHECK_op, NOTREACHED, CHECK_op respectively.

BUG=697688

R=SamsungPeerReview
==========

[nikhil.sahni, 2017-03-14 05:15:12]

nikhil.sahni@samsung.com changed reviewers:
+ shanmuga.m@samsung.com

[nikhil.sahni, 2017-03-14 05:16:18]

nikhil.sahni@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Shanmuga Pandi, 2017-03-14 05:24:25]

Peer review looks good to me.

[Srirama, 2017-03-14 05:31:52]

nit: Remove RELEASE_ASSERT part from the description.

[nikhil.sahni, 2017-03-14 05:40:41]

Description was changed from

==========
Replace  ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/

Replacing ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/style/
with DCHECK_op, NOTREACHED, CHECK_op respectively.

BUG=697688

R=SamsungPeerReview
==========

to

==========
Replace  ASSERT and  ASSERT_NOT_REACHED in core/style/

Replacing ASSERT and ASSERT_NOT_REACHED in core/style/
with DCHECK_op, NOTREACHED respectively.

BUG=697688
==========

[nikhil.sahni, 2017-03-14 05:41:48]

nikhil.sahni@samsung.com changed reviewers:
+ tkent@chromium.org

[nikhil.sahni, 2017-03-14 07:41:20]

nikhil.sahni@samsung.com changed reviewers:
+ meade@chromium.org

[nikhil.sahni, 2017-03-15 04:57:52]

On 2017/03/14 05:31:52, Srirama wrote:
> nit: Remove RELEASE_ASSERT part from the description.

[nikhil.sahni, 2017-03-15 04:58:20]

On 2017/03/15 04:57:52, nikhil.sahni wrote:
> On 2017/03/14 05:31:52, Srirama wrote:
> > nit: Remove RELEASE_ASSERT part from the description.

done.

[tkent, 2017-03-15 05:02:21]

https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/BasicShapes.cpp (right):

https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/BasicShapes.cpp:205: DCHECK(other &&
isSameType(*other));
Please split it to two DCHEKS.
  DCHECK(other);
  DCHECK(isSameType(*other));

https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/BasicShapes.cpp:275: DCHECK(other &&
isSameType(*other));
Please split it to two DCHEKS.
  DCHECK(other);
  DCHECK(isSameType(*other));

https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/GridPositionsResolver.cpp (right):

https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/GridPositionsResolver.cpp:374:
DCHECK(initialPosition.shouldBeResolvedAgainstOppositePosition() &&
Please split it to two DCHEKS.
  DCHECK(initialPosition.shouldBeResolvedAgainstOppositePosition());
  DCHECK(finalPosition.shouldBeResolvedAgainstOppositePosition());

[nikhil.sahni, 2017-03-15 05:26:52]

On 2017/03/15 05:02:21, tkent wrote:
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/style/BasicShapes.cpp (right):
> 
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/style/BasicShapes.cpp:205: DCHECK(other &&
> isSameType(*other));
> Please split it to two DCHEKS.
>   DCHECK(other);
>   DCHECK(isSameType(*other));
> 
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/style/BasicShapes.cpp:275: DCHECK(other &&
> isSameType(*other));
> Please split it to two DCHEKS.
>   DCHECK(other);
>   DCHECK(isSameType(*other));
> 
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/style/GridPositionsResolver.cpp (right):
> 
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/style/GridPositionsResolver.cpp:374:
> DCHECK(initialPosition.shouldBeResolvedAgainstOppositePosition() &&
> Please split it to two DCHEKS.
>   DCHECK(initialPosition.shouldBeResolvedAgainstOppositePosition());
>   DCHECK(finalPosition.shouldBeResolvedAgainstOppositePosition());

Thanks for your review, Done the specified changes .

[nikhil.sahni, 2017-03-15 05:26:52]

On 2017/03/15 05:02:21, tkent wrote:
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/style/BasicShapes.cpp (right):
> 
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/style/BasicShapes.cpp:205: DCHECK(other &&
> isSameType(*other));
> Please split it to two DCHEKS.
>   DCHECK(other);
>   DCHECK(isSameType(*other));
> 
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/style/BasicShapes.cpp:275: DCHECK(other &&
> isSameType(*other));
> Please split it to two DCHEKS.
>   DCHECK(other);
>   DCHECK(isSameType(*other));
> 
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/style/GridPositionsResolver.cpp (right):
> 
>
https://codereview.chromium.org/2751653003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/style/GridPositionsResolver.cpp:374:
> DCHECK(initialPosition.shouldBeResolvedAgainstOppositePosition() &&
> Please split it to two DCHEKS.
>   DCHECK(initialPosition.shouldBeResolvedAgainstOppositePosition());
>   DCHECK(finalPosition.shouldBeResolvedAgainstOppositePosition());

Thanks for your review, Done the specified changes .

[tkent, 2017-03-15 05:28:21]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-03-15 05:28:22]

lgtm

[commit-bot: I haz the power, 2017-03-15 05:28:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 05:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 05:28:38]

The author nikhil.sahni@samsung.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[Srirama, 2017-03-16 13:43:56]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2017-03-16 13:44:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 15:12:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489671836070900,
"parent_rev": "14a2141814db4d7f906a3bf7902ecb2a99a82f08", "commit_rev":
"8ef33b2cfea95309080e9d7f452233e0e780d5d8"}

[commit-bot: I haz the power, 2017-03-16 15:13:07]

Description was changed from

==========
Replace  ASSERT and  ASSERT_NOT_REACHED in core/style/

Replacing ASSERT and ASSERT_NOT_REACHED in core/style/
with DCHECK_op, NOTREACHED respectively.

BUG=697688
==========

to

==========
Replace  ASSERT and  ASSERT_NOT_REACHED in core/style/

Replacing ASSERT and ASSERT_NOT_REACHED in core/style/
with DCHECK_op, NOTREACHED respectively.

BUG=697688

Review-Url: https://codereview.chromium.org/2751653003
Cr-Commit-Position: refs/heads/master@{#457437}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ef33b2cfea95309080e9d7f4522...
==========

[commit-bot: I haz the power, 2017-03-16 15:13:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8ef33b2cfea95309080e9d7f4522...