Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2751573004: Image writer client: create mojo client with MakeUnique<> (Closed)

Created:
3 years, 9 months ago by Noel Gordon
Modified:
3 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Image writer client: create mojo client with MakeUnique<> Create the utility process mojo client with base::MakeUnique<>. Also append IfNeeded to the start utility process routine (since we don't start the utility process if it's already active). No change in behavior, no new tests. BUG=680928 Review-Url: https://codereview.chromium.org/2751573004 Cr-Commit-Position: refs/heads/master@{#456923} Committed: https://chromium.googlesource.com/chromium/src/+/2e4074d748dc65d528e01ef01c59ace2c5fb281f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc View 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Noel Gordon
Some mojo clean-up.
3 years, 9 months ago (2017-03-14 13:18:54 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-14 20:09:58 UTC) #8
Sam McNally
lgtm
3 years, 9 months ago (2017-03-14 23:24:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751573004/1
3 years, 9 months ago (2017-03-15 00:20:42 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 00:48:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e4074d748dc65d528e01ef01c59...

Powered by Google App Engine
This is Rietveld 408576698