Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2751573003: [debugger] correctly find inner function scope. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
kozy, jgruber
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] correctly find inner function scope. Nested arrow functions can have the same end positions, so the end position is unsuitable to decide whether a scope is an inner function scope. BUG=chromium:696202 R=jgruber@chromium.org, kozyatinskiy@chromium.org Review-Url: https://codereview.chromium.org/2751573003 Cr-Commit-Position: refs/heads/master@{#43797} Committed: https://chromium.googlesource.com/v8/v8/+/62b6dd194216e734bbaf98bb144a87bd149a94f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M src/debug/debug-scopes.cc View 1 chunk +5 lines, -1 line 0 comments Download
A test/inspector/debugger/step-into-nested-arrow.js View 1 chunk +23 lines, -0 lines 0 comments Download
A test/inspector/debugger/step-into-nested-arrow-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M test/inspector/protocol-test.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Yang
3 years, 9 months ago (2017-03-14 12:16:13 UTC) #1
kozy
lgtm
3 years, 9 months ago (2017-03-14 16:20:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751573003/1
3 years, 9 months ago (2017-03-14 16:33:45 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 16:35:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/62b6dd194216e734bbaf98bb144a87bd149...

Powered by Google App Engine
This is Rietveld 408576698