Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4802)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h

Issue 2751573002: [Mac] Refactor bookmark bar controller (Closed)
Patch Set: Restore unused button pool Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
index 7767861e0e35ee815c3f0452ac59009956151a41..f5df4161124f0d6aa6008eb663d27eb0b0b41e50 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
@@ -233,9 +233,6 @@ willAnimateFromState:(BookmarkBar::State)oldState
buttonView_; // Contains 'no items' text fields.
base::scoped_nsobject<BookmarkButton> offTheSideButton_; // aka the chevron.
- NSRect originalNoItemsRect_; // Original, pre-resized field rect.
- NSRect originalImportBookmarksRect_; // Original, pre-resized field rect.
-
// "Apps" button on the left side.
base::scoped_nsobject<BookmarkButton> appsPageShortcutButton_;
@@ -260,15 +257,6 @@ willAnimateFromState:(BookmarkBar::State)oldState
// initial build.
CGFloat savedFrameWidth_;
- // The number of buttons we display in the bookmark bar. This does
- // not include the "off the side" chevron or the "Other Bookmarks"
- // button. We use this number to determine if we need to display
- // the chevron, and to know what to place in the chevron's menu.
- // Since we create everything before doing layout we can't be sure
- // that all bookmark buttons we create will be visible. Thus,
- // [buttons_ count] isn't a definitive check.
- int displayedButtonCount_;
-
// A state flag which tracks when the bar's folder menus should be shown.
// An initial click in any of the folder buttons turns this on and
// one of the following will turn it off: another click in the button,
@@ -414,7 +402,6 @@ willAnimateFromState:(BookmarkBar::State)oldState
// the rest of Chromium. Internal to BookmarkBarController.
@interface BookmarkBarController(BridgeRedirect)
- (void)loaded:(bookmarks::BookmarkModel*)model;
-- (void)beingDeleted:(bookmarks::BookmarkModel*)model;
- (void)nodeAdded:(bookmarks::BookmarkModel*)model
parent:(const bookmarks::BookmarkNode*)oldParent index:(int)index;
- (void)nodeChanged:(bookmarks::BookmarkModel*)model
@@ -444,7 +431,6 @@ willAnimateFromState:(BookmarkBar::State)oldState
- (BookmarkButton*)otherBookmarksButton;
- (BookmarkBarFolderController*)folderController;
- (id)folderTarget;
-- (int)displayedButtonCount;
- (void)openURL:(GURL)url disposition:(WindowOpenDisposition)disposition;
- (void)clearBookmarkBar;
- (BookmarkButtonCell*)cellForBookmarkNode:(const bookmarks::BookmarkNode*)node;

Powered by Google App Engine
This is Rietveld 408576698