[Mac] Refactor bookmark bar controller

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_CONTROLLER_H_
 
 #import <Cocoa/Cocoa.h>
 #include <stdint.h>
 
@@ skipping 215 matching lines @@
   BookmarkBarFolderController* folderController_;
 
   // The event tap that allows monitoring of all events, to properly close with
   // a click outside the bounds of the window.
   id exitEventTap_;
 
   base::scoped_nsobject<BookmarkBarView>
       buttonView_;  // Contains 'no items' text fields.
   base::scoped_nsobject<BookmarkButton> offTheSideButton_;  // aka the chevron.
 
-  NSRect originalNoItemsRect_;  // Original, pre-resized field rect.
-  NSRect originalImportBookmarksRect_;  // Original, pre-resized field rect.
-
   // "Apps" button on the left side.
   base::scoped_nsobject<BookmarkButton> appsPageShortcutButton_;
 
   // "Managed bookmarks" button on the left side, next to the apps button.
   base::scoped_nsobject<BookmarkButton> managedBookmarksButton_;
 
   // "Supervised bookmarks" button on the left side, next to the apps button.
   base::scoped_nsobject<BookmarkButton> supervisedBookmarksButton_;
 
   // "Other bookmarks" button on the right side.
   base::scoped_nsobject<BookmarkButton> otherBookmarksButton_;
 
   // When doing a drag, this is folder button "hovered over" which we
   // may want to open after a short delay.  There are cases where a
   // mouse-enter can open a folder (e.g. if the menus are "active")
   // but that doesn't use this variable or need a delay so "hover" is
   // the wrong term.
   base::scoped_nsobject<BookmarkButton> hoverButton_;
 
   // We save the view width when we add bookmark buttons.  This lets
   // us avoid a rebuild until we've grown the window bigger than our
   // initial build.
   CGFloat savedFrameWidth_;
 
-  // The number of buttons we display in the bookmark bar.  This does
-  // not include the "off the side" chevron or the "Other Bookmarks"
-  // button.  We use this number to determine if we need to display
-  // the chevron, and to know what to place in the chevron's menu.
-  // Since we create everything before doing layout we can't be sure
-  // that all bookmark buttons we create will be visible.  Thus,
-  // [buttons_ count] isn't a definitive check.
-  int displayedButtonCount_;
-
   // A state flag which tracks when the bar's folder menus should be shown.
   // An initial click in any of the folder buttons turns this on and
   // one of the following will turn it off: another click in the button,
   // the window losing focus, a click somewhere other than in the bar
   // or a folder menu.
   BOOL showFolderMenus_;
 
   // If YES then state changes (for example, from hidden to shown) are animated.
   // This is turned off for unit tests.
   BOOL stateAnimationsEnabled_;
@@ skipping 125 matching lines @@
 
 // Returns the "off the side" button image.
 - (NSImage*)offTheSideButtonImage:(BOOL)forDarkMode;
 
 @end
 
 // Redirects from BookmarkBarBridge, the C++ object which glues us to
 // the rest of Chromium.  Internal to BookmarkBarController.
 @interface BookmarkBarController(BridgeRedirect)
 - (void)loaded:(bookmarks::BookmarkModel*)model;
-- (void)beingDeleted:(bookmarks::BookmarkModel*)model;
 - (void)nodeAdded:(bookmarks::BookmarkModel*)model
            parent:(const bookmarks::BookmarkNode*)oldParent index:(int)index;
 - (void)nodeChanged:(bookmarks::BookmarkModel*)model
                node:(const bookmarks::BookmarkNode*)node;
 - (void)nodeMoved:(bookmarks::BookmarkModel*)model
         oldParent:(const bookmarks::BookmarkNode*)oldParent
          oldIndex:(int)oldIndex
         newParent:(const bookmarks::BookmarkNode*)newParent
          newIndex:(int)newIndex;
 - (void)nodeRemoved:(bookmarks::BookmarkModel*)model
              parent:(const bookmarks::BookmarkNode*)oldParent
               index:(int)index;
 - (void)nodeFaviconLoaded:(bookmarks::BookmarkModel*)model
                      node:(const bookmarks::BookmarkNode*)node;
 - (void)nodeChildrenReordered:(bookmarks::BookmarkModel*)model
                          node:(const bookmarks::BookmarkNode*)node;
 @end
 
 // These APIs should only be used by unit tests (or used internally).
 @interface BookmarkBarController(InternalOrTestingAPI)
 - (void)openBookmarkFolder:(id)sender;
 - (void)openOrCloseBookmarkFolderForOffTheSideButton;
 - (BookmarkBarView*)buttonView;
 - (NSMutableArray*)buttons;
 - (BOOL)offTheSideButtonIsHidden;
 - (BOOL)appsPageShortcutButtonIsHidden;
 - (BookmarkButton*)otherBookmarksButton;
 - (BookmarkBarFolderController*)folderController;
 - (id)folderTarget;
-- (int)displayedButtonCount;
 - (void)openURL:(GURL)url disposition:(WindowOpenDisposition)disposition;
 - (void)clearBookmarkBar;
 - (BookmarkButtonCell*)cellForBookmarkNode:(const bookmarks::BookmarkNode*)node;
 - (BookmarkButtonCell*)cellForCustomButtonWithText:(NSString*)text
                                              image:(NSImage*)image;
 - (NSRect)frameForBookmarkButtonFromCell:(NSCell*)cell xOffset:(int*)xOffset;
 - (void)checkForBookmarkButtonGrowth:(NSButton*)button;
 - (void)frameDidChange;
 - (int64_t)nodeIdFromMenuTag:(int32_t)tag;
 - (int32_t)menuTagFromNodeId:(int64_t)menuid;
 - (void)updateTheme:(const ui::ThemeProvider*)themeProvider;
 - (BookmarkButton*)buttonForDroppingOnAtPoint:(NSPoint)point;
 - (BOOL)isEventAnExitEvent:(NSEvent*)event;
 - (BOOL)shrinkOrHideView:(NSView*)view forMaxX:(CGFloat)maxViewX;
 - (void)unhighlightBookmark:(const bookmarks::BookmarkNode*)node;
 
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_CONTROLLER_H_