Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2467)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm

Issue 2751573002: [Mac] Refactor bookmark bar controller (Closed)
Patch Set: Restore unused button pool Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm
index 16fa24fd9574174d053dc7541365323a6db0e8ee..58811b0d8c467f1110e4065513a3056a7f3d7f06 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm
@@ -51,9 +51,11 @@ void BookmarkBarBridge::BookmarkModelLoaded(BookmarkModel* model,
}
void BookmarkBarBridge::BookmarkModelBeingDeleted(BookmarkModel* model) {
Elly Fong-Jones 2017/03/23 15:40:21 can this happen in other circumstances than the br
- [controller_ beingDeleted:model];
model_->RemoveObserver(this);
model_ = nullptr;
+ // The browser may be being torn down; little is safe to do. As an
+ // example, it may not be safe to clear the pasteboard.
+ // http://crbug.com/38665
}
void BookmarkBarBridge::BookmarkNodeMoved(BookmarkModel* model,

Powered by Google App Engine
This is Rietveld 408576698