Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2751563002: [DevTools] Do not clip text for multi-line toolbar (Closed)

Created:
3 years, 9 months ago by eostroukhov
Modified:
3 years, 9 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not clip text for multi-line toolbar BUG=696460 Review-Url: https://codereview.chromium.org/2751563002 Cr-Commit-Position: refs/heads/master@{#456551} Committed: https://chromium.googlesource.com/chromium/src/+/c3cb4770dc953564b29c9bedb5f80f02f71a950c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
eostroukhov
Please take a look.
3 years, 9 months ago (2017-03-13 22:02:50 UTC) #3
dgozman
lgtm https://codereview.chromium.org/2751563002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css File third_party/WebKit/Source/devtools/front_end/ui/toolbar.css (right): https://codereview.chromium.org/2751563002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css#newcode25 third_party/WebKit/Source/devtools/front_end/ui/toolbar.css:25: overflow: visible; Please double-check device mode's top toolbar.
3 years, 9 months ago (2017-03-13 22:29:52 UTC) #5
eostroukhov
On 2017/03/13 22:29:52, dgozman wrote: > lgtm > > https://codereview.chromium.org/2751563002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css > File third_party/WebKit/Source/devtools/front_end/ui/toolbar.css (right): > ...
3 years, 9 months ago (2017-03-13 22:55:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751563002/1
3 years, 9 months ago (2017-03-13 22:55:59 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:50:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3cb4770dc953564b29c9bedb5f8...

Powered by Google App Engine
This is Rietveld 408576698