Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2751543005: MD Bookmarks: Use consistent 'state' variable in reducers_test.js (Closed)

Created:
3 years, 9 months ago by tsergeant
Modified:
3 years, 9 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Use consistent 'state' variable in reducers_test.js This eliminates the unnecessary distinction between 'initialState' and 'nextState'. BUG=697706 Review-Url: https://codereview.chromium.org/2751543005 Cr-Commit-Position: refs/heads/master@{#457352} Committed: https://chromium.googlesource.com/chromium/src/+/0ea824c6614b1cc7f3e8b725fc138ba23518fb4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -49 lines) Patch
M chrome/test/data/webui/md_bookmarks/reducers_test.js View 2 chunks +46 lines, -49 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
tsergeant
to-done
3 years, 9 months ago (2017-03-15 23:03:06 UTC) #4
calamity
lgtm.
3 years, 9 months ago (2017-03-16 03:53:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751543005/1
3 years, 9 months ago (2017-03-16 03:59:55 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 04:46:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ea824c6614b1cc7f3e8b725fc13...

Powered by Google App Engine
This is Rietveld 408576698