Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2751523008: Update Background Fetch IDLs following spec changes (Closed)

Created:
3 years, 9 months ago by Peter Beverloo
Modified:
3 years, 9 months ago
Reviewers:
haraken, harkness
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, awdf+watch_chromium.org, shimazu+serviceworker_chromium.org, Peter Beverloo, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, harkness+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Background Fetch IDLs following spec changes Jake pushed two changes to the spec yesterday. This CL aligns our implementation with them: https://github.com/WICG/background-fetch/commit/5d399383 "Renaming in progress fetches to activeFetches, renaming settled fetches to fetches." https://github.com/WICG/background-fetch/commit/ffabe2fe "Fixing incorrect use of plurals." BUG=692534 Review-Url: https://codereview.chromium.org/2751523008 Cr-Commit-Position: refs/heads/master@{#457576} Committed: https://chromium.googlesource.com/chromium/src/+/0bdf346c6a54fc63be0a3f248631747c0a3745b7

Patch Set 1 #

Patch Set 2 : fix links #

Patch Set 3 : rebase #

Patch Set 4 : Update Background Fetch IDLs following spec changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -251 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-fail-event-worker.js View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetched-event-worker.js View 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BUILD.gn View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFetch.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFetch.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFetch.idl View 1 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRequest.h View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRequest.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRequest.idl View 1 chunk +0 lines, -14 lines 0 comments Download
A + third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.h View 3 chunks +9 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.idl View 1 1 chunk +2 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledRequest.h View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledRequest.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledRequest.idl View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Peter Beverloo
+harkness for review
3 years, 9 months ago (2017-03-16 13:47:25 UTC) #2
harkness
lgtm
3 years, 9 months ago (2017-03-16 17:52:59 UTC) #7
haraken
gn LGTM
3 years, 9 months ago (2017-03-16 17:54:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751523008/20001
3 years, 9 months ago (2017-03-16 17:59:45 UTC) #10
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-16 18:10:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751523008/40001
3 years, 9 months ago (2017-03-16 18:22:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/229989) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 9 months ago (2017-03-16 18:26:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751523008/60001
3 years, 9 months ago (2017-03-16 19:37:05 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 22:05:31 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0bdf346c6a54fc63be0a3f248631...

Powered by Google App Engine
This is Rietveld 408576698