Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2751523005: MD Settings: bump iron-list version. (Closed)

Created:
3 years, 9 months ago by scottchen
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: bump iron-list version. Primarily to address an issue we're seeing in Settings where initial clicks on certain row items aren't being registered. BUG=697353 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751523005 Cr-Commit-Position: refs/heads/master@{#457373} Committed: https://chromium.googlesource.com/chromium/src/+/9e099d4c84b02fe2a6ee52883090a974ceb8cfd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -109 lines) Patch
M third_party/polymer/v1_0/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/bower.json View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html View 6 chunks +17 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js View 32 chunks +143 lines, -92 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
scottchen
3 years, 9 months ago (2017-03-15 00:32:24 UTC) #3
scottchen
3 years, 9 months ago (2017-03-15 00:32:27 UTC) #4
Dan Beam
you have to fix the closure externs
3 years, 9 months ago (2017-03-15 17:53:13 UTC) #9
Dan Beam
lgtm, i'm pretty sure i fixed the closure stuff around this CL and it should ...
3 years, 9 months ago (2017-03-16 04:24:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751523005/1
3 years, 9 months ago (2017-03-16 04:41:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/384798)
3 years, 9 months ago (2017-03-16 07:29:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751523005/1
3 years, 9 months ago (2017-03-16 08:09:59 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 08:50:18 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e099d4c84b02fe2a6ee52883090...

Powered by Google App Engine
This is Rietveld 408576698