Move EarlGrey helper to check toolbar visibility into ChromeEarlGreyUI.

Move EarlGrey helper to check toolbar visibility into ChromeEarlGreyUI.

Delete chrome_util.h/mm, since it was a temporary location for
utility methods. Change the method from one that waits and asserts
to one that waits and returns YES on success, and NO on failure.

BUG=660491
Review-Url: https://codereview.chromium.org/2751523004
Cr-Commit-Position: refs/heads/master@{#456929}
Committed: https://chromium.googlesource.com/chromium/src/+/a1a5ce8907afdad37a43b5fafc266be318aa491a

[baxley, 2017-03-14 22:22:02]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[baxley, 2017-03-14 22:22:04]

review suggestion - look at the changes to chrome_earl_grey_ui.mm first.

Thanks!

https://codereview.chromium.org/2751523004/diff/20001/ios/chrome/test/earl_gr...
File ios/chrome/test/earl_grey/chrome_earl_grey_ui.h (right):

https://codereview.chromium.org/2751523004/diff/20001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_earl_grey_ui.h:35: +
(BOOL)waitForToolbarVisible:(BOOL)isVisible;
I made this method wait since in at least one case tapping a webview link was
resulting in the toolbar disappearing (or showing).

[Eugene But (OOO till 7-30), 2017-03-14 22:37:47]

lgtm but we should make sure that all WaitFor methods are consistent and either
return bool or assert.

https://codereview.chromium.org/2751523004/diff/20001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/fullscreen_egtest.mm (right):

https://codereview.chromium.org/2751523004/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/fullscreen_egtest.mm:140: ;
Extra semicolon. Same comment for many other places.

[baxley, 2017-03-14 23:16:33]

Opted to return void and assert. This will prevent users from forgetting to
assert in the test, and maintaining consistency.

https://codereview.chromium.org/2751523004/diff/20001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/fullscreen_egtest.mm (right):

https://codereview.chromium.org/2751523004/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/fullscreen_egtest.mm:140: ;
On 2017/03/14 22:37:47, Eugene But wrote:
> Extra semicolon. Same comment for many other places.

Done.

[baxley, 2017-03-14 23:16:49]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-03-14 23:16:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2751523004/#ps40001
(title: "return void")

[commit-bot: I haz the power, 2017-03-14 23:18:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 01:00:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489533409336020,
"parent_rev": "981ff3850e661dae2425f4183aeb1dc8c1104d19", "commit_rev":
"a1a5ce8907afdad37a43b5fafc266be318aa491a"}

[commit-bot: I haz the power, 2017-03-15 01:01:13]

Description was changed from

==========
Move EarlGrey helper to check toolbar visibility into ChromeEarlGreyUI.

Delete chrome_util.h/mm, since it was a temporary location for
utility methods. Change the method from one that waits and asserts
to one that waits and returns YES on success, and NO on failure.

BUG=660491
==========

to

==========
Move EarlGrey helper to check toolbar visibility into ChromeEarlGreyUI.

Delete chrome_util.h/mm, since it was a temporary location for
utility methods. Change the method from one that waits and asserts
to one that waits and returns YES on success, and NO on failure.

BUG=660491

Review-Url: https://codereview.chromium.org/2751523004
Cr-Commit-Position: refs/heads/master@{#456929}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1a5ce8907afdad37a43b5fafc26...
==========

[commit-bot: I haz the power, 2017-03-15 01:01:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a1a5ce8907afdad37a43b5fafc26...