Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2751513006: [turbofan] Fix typing for NumberMin and NumberMax to handle uninhabited types. (Closed)

Created:
3 years, 9 months ago by Jarin
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, neis
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix typing for NumberMin and NumberMax to handle uninhabited types. BUG=chromium:700883 Review-Url: https://codereview.chromium.org/2751513006 Cr-Commit-Position: refs/heads/master@{#43812} Committed: https://chromium.googlesource.com/v8/v8/+/5790aad42511f8dc2c6311981a2050922200ede4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/compiler/operation-typer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-700883.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
Could you take a look, please?
3 years, 9 months ago (2017-03-15 07:02:09 UTC) #6
Benedikt Meurer
lgtm
3 years, 9 months ago (2017-03-15 07:43:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751513006/1
3 years, 9 months ago (2017-03-15 07:43:52 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 07:46:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5790aad42511f8dc2c6311981a205092220...

Powered by Google App Engine
This is Rietveld 408576698