Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2751513004: [parser] Delete misplaced const. (Closed)

Created:
3 years, 9 months ago by Franzi
Modified:
3 years, 9 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Delete misplaced const. 'const' type qualifier on return type has no effect and produces compiler warnings. BUG= Review-Url: https://codereview.chromium.org/2751513004 Cr-Commit-Position: refs/heads/master@{#43839} Committed: https://chromium.googlesource.com/v8/v8/+/90e860ca91bee6830b0c68da15024d63da32fef9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/parsing/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Franzi
PTAL. Thanks
3 years, 9 months ago (2017-03-14 14:50:44 UTC) #7
marja
lgtm
3 years, 9 months ago (2017-03-15 17:20:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751513004/1
3 years, 9 months ago (2017-03-15 18:27:11 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 18:48:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/90e860ca91bee6830b0c68da15024d63da3...

Powered by Google App Engine
This is Rietveld 408576698