Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2751513003: Small fixes to update_node.py. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Small fixes to update_node.py. BUG=v8:6091 R=machenbach@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2751513003 Cr-Commit-Position: refs/heads/master@{#43768} Committed: https://chromium.googlesource.com/v8/v8/+/a5eec0ca0b09386c88e8d723f9bf1088368a5ee3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/release/test_update_node.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/release/testdata/v8/.gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/release/update_node.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Yang
3 years, 9 months ago (2017-03-14 09:26:00 UTC) #1
Michael Achenbach
lgtm, thanks!
3 years, 9 months ago (2017-03-14 09:29:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751513003/1
3 years, 9 months ago (2017-03-14 09:30:28 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 09:36:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a5eec0ca0b09386c88e8d723f9bf1088368...

Powered by Google App Engine
This is Rietveld 408576698