Fix org.chromium.android_webview.test.AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload …

Fix org.chromium.android_webview.test.AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload with PlzNavigate.

The test is meant to verify that a reload occurs if the user agent override is set during a navigation. It was testing that by looking for two did-stop-navigation events, which is an implementation detail fo the old navigation code paths. With PlzNavigate, only one did-stop-navigation callback is fired. Change the test to look for a history entry with reload=true instead.

BUG=645983
Review-Url: https://codereview.chromium.org/2751493002
Cr-Commit-Position: refs/heads/master@{#456581}
Committed: https://chromium.googlesource.com/chromium/src/+/55e6fd485c6e8dd9ee7f69627ce1068cfb7c4e50

[jam, 2017-03-13 20:38:40]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 20:39:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-13 20:41:49]

jam@chromium.org changed reviewers:
+ sgurun@chromium.org

[commit-bot: I haz the power, 2017-03-13 21:22:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 21:22:52]

Dry run: This issue passed the CQ dry run.

[sgurun-gerrit only, 2017-03-13 23:58:07]

On 2017/03/13 20:41:50, jam wrote:

lgtm

[jam, 2017-03-14 00:05:58]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:06:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:24:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489449958355740,
"parent_rev": "3d0d1cdfad3fd70d8d579dd03004b4e09d01f2f1", "commit_rev":
"55e6fd485c6e8dd9ee7f69627ce1068cfb7c4e50"}

[commit-bot: I haz the power, 2017-03-14 02:25:12]

Description was changed from

==========
Fix
org.chromium.android_webview.test.AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload
with PlzNavigate.

The test is meant to verify that a reload occurs if the user agent override is
set during a navigation. It was testing that by looking for two
did-stop-navigation events, which is an implementation detail fo the old
navigation code paths. With PlzNavigate, only one did-stop-navigation callback
is fired. Change the test to look for a history entry with reload=true instead.

BUG=645983
==========

to

==========
Fix
org.chromium.android_webview.test.AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload
with PlzNavigate.

The test is meant to verify that a reload occurs if the user agent override is
set during a navigation. It was testing that by looking for two
did-stop-navigation events, which is an implementation detail fo the old
navigation code paths. With PlzNavigate, only one did-stop-navigation callback
is fired. Change the test to look for a history entry with reload=true instead.

BUG=645983

Review-Url: https://codereview.chromium.org/2751493002
Cr-Commit-Position: refs/heads/master@{#456581}
Committed:
https://chromium.googlesource.com/chromium/src/+/55e6fd485c6e8dd9ee7f69627ce1...
==========

[commit-bot: I haz the power, 2017-03-14 02:25:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55e6fd485c6e8dd9ee7f69627ce1...