Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2751443002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 8 months ago
CC:
falken, chromium-reviews, mlamouri+watch-content_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, jam, darin-cc_chromium.org, blink-worker-reviews_chromium.org, oshima+watch_chromium.org, kinuko+watch, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (policy, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=atwilson@chromium.org Review-Url: https://codereview.chromium.org/2751443002 Cr-Commit-Position: refs/heads/master@{#462539} Committed: https://chromium.googlesource.com/chromium/src/+/fbee199b22eeee99ede082592e7001dd45879f84

Patch Set 1 #

Patch Set 2 : Add TEAM/COMPONENT #

Patch Set 3 : remove shared_workers OWENRS files #

Total comments: 8

Patch Set 4 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/background/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/status_icons/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-13 18:09:00 UTC) #2
falken
On 2017/03/13 18:09:00, ymzhang1 wrote: > Hello, > > We are adding COMPONENT/TEAM information into ...
3 years, 9 months ago (2017-03-14 03:45:15 UTC) #3
ymzhang1
Remove shared_workers changes from this CL.
3 years, 9 months ago (2017-03-14 23:34:31 UTC) #4
Andrew T Wilson (Slow)
https://codereview.chromium.org/2751443002/diff/40001/chrome/browser/background/OWNERS File chrome/browser/background/OWNERS (right): https://codereview.chromium.org/2751443002/diff/40001/chrome/browser/background/OWNERS#newcode3 chrome/browser/background/OWNERS:3: # COMPONENT: Blink>BackgroundSync This should be Platform>Apps>BackgroundPage https://codereview.chromium.org/2751443002/diff/40001/chrome/browser/chromeos/policy/OWNERS File ...
3 years, 8 months ago (2017-03-31 07:37:28 UTC) #5
ymzhang1
https://codereview.chromium.org/2751443002/diff/40001/chrome/browser/background/OWNERS File chrome/browser/background/OWNERS (right): https://codereview.chromium.org/2751443002/diff/40001/chrome/browser/background/OWNERS#newcode3 chrome/browser/background/OWNERS:3: # COMPONENT: Blink>BackgroundSync On 2017/03/31 07:37:27, Andrew T Wilson ...
3 years, 8 months ago (2017-03-31 16:09:20 UTC) #6
Andrew T Wilson (Slow)
lgtm
3 years, 8 months ago (2017-04-06 13:14:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751443002/60001
3 years, 8 months ago (2017-04-06 17:15:07 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 17:57:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fbee199b22eeee99ede082592e70...

Powered by Google App Engine
This is Rietveld 408576698