Start archiving metrics_metadata with builds.

Start archiving metrics_metadata with builds.

BUG=699328
Review-Url: https://codereview.chromium.org/2751423003
Cr-Commit-Position: refs/heads/master@{#461822}
Committed: https://chromium.googlesource.com/chromium/src/+/bef6eb324513ab51540335f40abbc4e434caf833

[Steven Holte, 2017-03-16 18:33:40]

Description was changed from

==========
Add metrics_metadata archive to windows FILES.cfg

BUG=699328
==========

to

==========
Start archiving metrics_metadata with builds.

BUG=699328
==========

[Steven Holte, 2017-03-16 18:36:13]

holte@chromium.org changed reviewers:
+ asvitkine@chromium.org, mmoss@chromium.org

[Michael Moss, 2017-03-16 19:12:00]

lgtm

[Alexei Svitkine (slow), 2017-03-23 15:26:12]

lgtm

[Steven Holte, 2017-03-23 19:28:17]

The CQ bit was checked by holte@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:28:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:55:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:55:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Steven Holte, 2017-03-24 23:10:05]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-03-24 23:10:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mmoss@chromium.org
Link to the patchset: https://codereview.chromium.org/2751423003/#ps20001
(title: "Fix BUILD.gn file")

[commit-bot: I haz the power, 2017-03-24 23:10:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 23:19:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 23:19:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Steven Holte, 2017-03-27 20:24:49]

holte@chromium.org changed reviewers:
+ dpranke@chromium.org

[Steven Holte, 2017-03-27 20:25:18]

+dpranke for BUILD.gn

[Dirk Pranke, 2017-04-01 01:20:39]

This will make the target build as part of "gn_all", but it's not clear to me
that that's actually the right dependency.

I guess this is better than before, so lgtm,  but I think we need to revisit the
approach of what is archived where and why. Perhaps there should be a target for
"stuff referenced by FILES.cfg" for example? Maybe FILES.cfg can be completely
replaced by GN targets and queries?

[Michael Moss, 2017-04-01 19:40:09]

On 2017/04/01 01:20:39, Dirk Pranke wrote:
> This will make the target build as part of "gn_all", but it's not clear to me
> that that's actually the right dependency.
> 
> I guess this is better than before, so lgtm,  but I think we need to revisit
the
> approach of what is archived where and why. Perhaps there should be a target
for
> "stuff referenced by FILES.cfg" for example? Maybe FILES.cfg can be completely
> replaced by GN targets and queries?

Not sure if this is coincidence, or you actually saw it already, but I opened
crbug.com/707465 just yesterday to propose that we replace all the current
archiving mess with GN targets.

[Dirk Pranke, 2017-04-01 21:26:40]

On 2017/04/01 19:40:09, Michael Moss wrote:
> On 2017/04/01 01:20:39, Dirk Pranke wrote:
> > This will make the target build as part of "gn_all", but it's not clear to
me
> > that that's actually the right dependency.
> > 
> > I guess this is better than before, so lgtm,  but I think we need to revisit
> the
> > approach of what is archived where and why. Perhaps there should be a target
> for
> > "stuff referenced by FILES.cfg" for example? Maybe FILES.cfg can be
completely
> > replaced by GN targets and queries?
> 
> Not sure if this is coincidence, or you actually saw it already, but I opened
> crbug.com/707465 just yesterday to propose that we replace all the current
> archiving mess with GN targets.

I thought you filed the bug in response to my comment, so I guess it's a
coincidence :).

[Steven Holte, 2017-04-04 18:37:33]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-04-04 18:37:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, mmoss@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2751423003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-04 18:38:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 20:41:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491331053816500,
"parent_rev": "728a4d51cdd2ccbd6e3e0e81dad77cdb0834f90f", "commit_rev":
"bef6eb324513ab51540335f40abbc4e434caf833"}

[commit-bot: I haz the power, 2017-04-04 20:42:16]

Description was changed from

==========
Start archiving metrics_metadata with builds.

BUG=699328
==========

to

==========
Start archiving metrics_metadata with builds.

BUG=699328

Review-Url: https://codereview.chromium.org/2751423003
Cr-Commit-Position: refs/heads/master@{#461822}
Committed:
https://chromium.googlesource.com/chromium/src/+/bef6eb324513ab51540335f40abb...
==========

[commit-bot: I haz the power, 2017-04-04 20:42:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bef6eb324513ab51540335f40abb...