Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2751363002: [csa] Replace remaining old-style GetProperty calls (Closed)

Created:
3 years, 9 months ago by jgruber
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Replace remaining old-style GetProperty calls Change Node* name = HeapConstant(name_string); Callable callable = CodeFactory::GetProperty(isolate); CallStub(callable, context, receiver, name); to GetProperty(context, receiver, name_string); BUG= Review-Url: https://codereview.chromium.org/2751363002 Cr-Commit-Position: refs/heads/master@{#43850} Committed: https://chromium.googlesource.com/v8/v8/+/10500cb79cd444c989e5ebe6a20f5c2cf94acc9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -101 lines) Patch
M src/builtins/builtins-array.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M src/builtins/builtins-conversion.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/builtins/builtins-promise.cc View 6 chunks +8 lines, -24 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 10 chunks +31 lines, -52 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jgruber
PTAL, should be all mechanic changes to GetProperty calls.
3 years, 9 months ago (2017-03-16 09:10:13 UTC) #4
Igor Sheludko
lgtm
3 years, 9 months ago (2017-03-16 09:22:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751363002/1
3 years, 9 months ago (2017-03-16 09:25:01 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 09:33:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/10500cb79cd444c989e5ebe6a20f5c2cf94...

Powered by Google App Engine
This is Rietveld 408576698