Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2751353002: Not Remove Non-Closable Arc Popup When Close Button is Pressed (Closed)

Created:
3 years, 9 months ago by yoshiki
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Not Remove Non-Closable Arc Popup When Close Button is Pressed * Fixes the issue: crbug.com/689220 - Adds ArcNotificationDelegate::Close method to handle the closing event - Not calls ArcCustomNotificationItem::Close() when the close button is pressed * Refines the code - Uses the same method MessageView::OnCloseButtonPressed() both from custom and normal notification BUG=689220 Review-Url: https://codereview.chromium.org/2668583005 Cr-Commit-Position: refs/heads/master@{#454814} (cherry picked from commit 9739ee62037118f47be3dab9701164c428b02e5b) Review-Url: https://codereview.chromium.org/2751353002 . Cr-Commit-Position: refs/branch-heads/3029@{#228} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/900e772bd5b5367e86fcb13c315807470696d081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M ui/arc/notification/arc_custom_notification_item.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 2 chunks +10 lines, -1 line 0 comments Download
M ui/message_center/views/custom_notification_view.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/message_center/views/message_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/views/message_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
yoshiki
3 years, 9 months ago (2017-03-16 06:22:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
900e772bd5b5367e86fcb13c315807470696d081.

Powered by Google App Engine
This is Rietveld 408576698