Chromium Code Reviews
DescriptionNot Remove Non-Closable Arc Popup When Close Button is Pressed
* Fixes the issue: crbug.com/689220
- Adds ArcNotificationDelegate::Close method to handle the closing event
- Not calls ArcCustomNotificationItem::Close() when the close button is pressed
* Refines the code
- Uses the same method MessageView::OnCloseButtonPressed() both from custom and normal notification
BUG=689220
Review-Url: https://codereview.chromium.org/2668583005
Cr-Commit-Position: refs/heads/master@{#454814}
(cherry picked from commit 9739ee62037118f47be3dab9701164c428b02e5b)
Review-Url: https://codereview.chromium.org/2751353002 .
Cr-Commit-Position: refs/branch-heads/3029@{#228}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/900e772bd5b5367e86fcb13c315807470696d081
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||