Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingNetworkPermissionManager.java

Issue 2751333004: [Crash Reporting] Only upload Chrome crash reports over unmetered networks. (Closed)
Patch Set: This is the last self-review patch set, I swear! :-P Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingNetworkPermissionManager.java
diff --git a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingNetworkPermissionManager.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingNetworkPermissionManager.java
new file mode 100644
index 0000000000000000000000000000000000000000..2b01bfde20edf1fe6991c3abd86c062265f2c174
--- /dev/null
+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingNetworkPermissionManager.java
@@ -0,0 +1,20 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.components.minidump_uploader.util;
+
+import android.net.ConnectivityManager;
+import android.net.NetworkInfo;
+
+/**
+ * A container for determining whether it's ok to upload crash reports over the currently active
+ * network.
+ */
+public class CrashReportingNetworkPermissionManager {
Maria 2017/03/17 04:04:28 given that there's nothing specific to crash repor
Maria 2017/03/17 04:04:28 FYI, you are missing a BUILD file change to add th
gsennton 2017/03/20 17:29:01 +1 for the name change
Ilya Sherman 2017/03/20 23:11:21 Done.
Ilya Sherman 2017/03/20 23:11:21 Done.
+ static boolean isNetworkUnmetered(ConnectivityManager connectivityManager) {
+ NetworkInfo networkInfo = connectivityManager.getActiveNetworkInfo();
+ if (networkInfo == null || !networkInfo.isConnected()) return false;
+ return !mConnectivityManager.isActiveNetworkMetered();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698